* [ethtool PATCH v4 0/4] Add support for QSFP+/QSFP28 Diagnostics and 25G/50G/100G port speeds
@ 2016-08-23 13:30 Vidya Sagar Ravipati
2016-08-24 4:29 ` Yuval Mintz
2016-08-24 20:01 ` John W. Linville
0 siblings, 2 replies; 6+ messages in thread
From: Vidya Sagar Ravipati @ 2016-08-23 13:30 UTC (permalink / raw)
To: linville, netdev, davem
Cc: decot, bkenward, daniel, galp, roopa, gospo, dustin, ben
From: Vidya Sagar Ravipati <vidya@cumulusnetworks.com>
This patch series provides following support
a) Reorganized fields based out of SFF-8024 fields i.e. Identifier/
Encoding/Connector types which are common across SFP/SFP+ (SFF-8472)
and QSFP+/QSFP28 (SFF-8436/SFF-8636) modules into sff-common files.
b) Support for diagnostics information for QSFP Plus/QSFP28 modules
based on SFF-8436/SFF-8636
c) Supporting 25G/50G/100G speeds in supported/advertising fields
d) Tested across various QSFP+/QSFP28 Copper/Optical modules
Standards for QSFP+/QSFP28
a) QSFP+/QSFP28 - SFF 8636 Rev 2.7 dated January 26,2016
b) SFF-8024 Rev 4.0 dated May 31, 2016
v4:
Sync ethtool-copy.h to kernel commit 89da45b8b5b2187734a11038b8593714f964ffd1
which includes support for 50G base SR2
v3:
Review comments from Ben Hutchings:
Make sff diags structure common across sfpdiag.c and
qsfp.c and use common function to print common threshold
values.
Review comments from Rami Rosen:
Cleanup description messages.
v2:
Included support for 25G/50G/100G speeds in supported/
advertised speed modes
Review comments from Ben Hutchings:
Split the sff-8024 reorganzing patch and QSFP+/QSFP28
patch
Fixed all checkpatch warnings (except couple of over 80 character)
v1:
Support for SFF-8636 Rev 2.7
Review comments from Ben Hutchings:
Updating copyright holders information for QSFP
Reusing the common functions and macros across sfpid and qsfp
Vidya Sagar Ravipati (4):
ethtool-copy.h:sync with net
ethtool:Reorganizing SFF-8024 fields for SFP/QSFP
ethtool:QSFP Plus/QSFP28 Diagnostics Information Support
ethtool: Enhancing link mode bits to support 25G/50G/100G
Makefile.am | 2 +-
ethtool-copy.h | 18 +-
ethtool.c | 35 +++
internal.h | 3 +
qsfp.c | 788 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++
qsfp.h | 595 +++++++++++++++++++++++++++++++++++++++++++
sff-common.c | 304 ++++++++++++++++++++++
sff-common.h | 189 ++++++++++++++
sfpdiag.c | 105 +-------
sfpid.c | 103 +-------
10 files changed, 1945 insertions(+), 197 deletions(-)
create mode 100644 qsfp.c
create mode 100644 qsfp.h
create mode 100644 sff-common.c
create mode 100644 sff-common.h
--
2.1.4
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [ethtool PATCH v4 0/4] Add support for QSFP+/QSFP28 Diagnostics and 25G/50G/100G port speeds
2016-08-23 13:30 [ethtool PATCH v4 0/4] Add support for QSFP+/QSFP28 Diagnostics and 25G/50G/100G port speeds Vidya Sagar Ravipati
@ 2016-08-24 4:29 ` Yuval Mintz
2016-08-24 14:33 ` John W. Linville
2016-08-24 20:01 ` John W. Linville
1 sibling, 1 reply; 6+ messages in thread
From: Yuval Mintz @ 2016-08-24 4:29 UTC (permalink / raw)
To: Vidya Sagar Ravipati, linville@tuxdriver.com, netdev,
David Miller
Cc: decot@googlers.com, bkenward@solarflare.com, daniel@iogearbox.net,
galp@mellanox.com, roopa@cumulusnetworks.com,
gospo@cumulusnetworks.com, dustin@cumulusnetworks.com,
ben@decadent.org.uk
> This patch series provides following support
> a) Reorganized fields based out of SFF-8024 fields i.e. Identifier/
> Encoding/Connector types which are common across SFP/SFP+ (SFF-8472)
> and QSFP+/QSFP28 (SFF-8436/SFF-8636) modules into sff-common files.
> b) Support for diagnostics information for QSFP Plus/QSFP28 modules
> based on SFF-8436/SFF-8636
> c) Supporting 25G/50G/100G speeds in supported/advertising fields
> d) Tested across various QSFP+/QSFP28 Copper/Optical modules
>
> Standards for QSFP+/QSFP28
> a) QSFP+/QSFP28 - SFF 8636 Rev 2.7 dated January 26,2016
> b) SFF-8024 Rev 4.0 dated May 31, 2016
>
> v4:
> Sync ethtool-copy.h to kernel commit
> 89da45b8b5b2187734a11038b8593714f964ffd1
> which includes support for 50G base SR2
What about the man-page?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [ethtool PATCH v4 0/4] Add support for QSFP+/QSFP28 Diagnostics and 25G/50G/100G port speeds
2016-08-24 4:29 ` Yuval Mintz
@ 2016-08-24 14:33 ` John W. Linville
2016-08-24 20:01 ` John W. Linville
0 siblings, 1 reply; 6+ messages in thread
From: John W. Linville @ 2016-08-24 14:33 UTC (permalink / raw)
To: Yuval Mintz
Cc: Vidya Sagar Ravipati, netdev, David Miller, decot@googlers.com,
bkenward@solarflare.com, daniel@iogearbox.net, galp@mellanox.com,
roopa@cumulusnetworks.com, gospo@cumulusnetworks.com,
dustin@cumulusnetworks.com, ben@decadent.org.uk
On Wed, Aug 24, 2016 at 04:29:22AM +0000, Yuval Mintz wrote:
> > This patch series provides following support
> > a) Reorganized fields based out of SFF-8024 fields i.e. Identifier/
> > Encoding/Connector types which are common across SFP/SFP+ (SFF-8472)
> > and QSFP+/QSFP28 (SFF-8436/SFF-8636) modules into sff-common files.
> > b) Support for diagnostics information for QSFP Plus/QSFP28 modules
> > based on SFF-8436/SFF-8636
> > c) Supporting 25G/50G/100G speeds in supported/advertising fields
> > d) Tested across various QSFP+/QSFP28 Copper/Optical modules
> >
> > Standards for QSFP+/QSFP28
> > a) QSFP+/QSFP28 - SFF 8636 Rev 2.7 dated January 26,2016
> > b) SFF-8024 Rev 4.0 dated May 31, 2016
> >
> > v4:
> > Sync ethtool-copy.h to kernel commit
> > 89da45b8b5b2187734a11038b8593714f964ffd1
> > which includes support for 50G base SR2
>
> What about the man-page?
I can just apply your man page patch on top.
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [ethtool PATCH v4 0/4] Add support for QSFP+/QSFP28 Diagnostics and 25G/50G/100G port speeds
2016-08-23 13:30 [ethtool PATCH v4 0/4] Add support for QSFP+/QSFP28 Diagnostics and 25G/50G/100G port speeds Vidya Sagar Ravipati
2016-08-24 4:29 ` Yuval Mintz
@ 2016-08-24 20:01 ` John W. Linville
2016-08-24 20:39 ` Vidya Sagar Ravipati
1 sibling, 1 reply; 6+ messages in thread
From: John W. Linville @ 2016-08-24 20:01 UTC (permalink / raw)
To: Vidya Sagar Ravipati
Cc: netdev, davem, decot, bkenward, daniel, galp, roopa, gospo,
dustin, ben
I have pushed this series. I did modify patches 3 and 4 a bit,
to properly update Makefile.am in order to keep "make distcheck"
from failing -- please be more careful in the future.
John
P.S. I have not yet tagged this as an official release, so please test!
On Tue, Aug 23, 2016 at 06:30:29AM -0700, Vidya Sagar Ravipati wrote:
> From: Vidya Sagar Ravipati <vidya@cumulusnetworks.com>
>
> This patch seryies provides following support
> a) Reorganized fields based out of SFF-8024 fields i.e. Identifier/
> Encoding/Connector types which are common across SFP/SFP+ (SFF-8472)
> and QSFP+/QSFP28 (SFF-8436/SFF-8636) modules into sff-common files.
> b) Support for diagnostics information for QSFP Plus/QSFP28 modules
> based on SFF-8436/SFF-8636
> c) Supporting 25G/50G/100G speeds in supported/advertising fields
> d) Tested across various QSFP+/QSFP28 Copper/Optical modules
>
> Standards for QSFP+/QSFP28
> a) QSFP+/QSFP28 - SFF 8636 Rev 2.7 dated January 26,2016
> b) SFF-8024 Rev 4.0 dated May 31, 2016
>
> v4:
> Sync ethtool-copy.h to kernel commit 89da45b8b5b2187734a11038b8593714f964ffd1
> which includes support for 50G base SR2
>
> v3:
> Review comments from Ben Hutchings:
> Make sff diags structure common across sfpdiag.c and
> qsfp.c and use common function to print common threshold
> values.
> Review comments from Rami Rosen:
> Cleanup description messages.
>
> v2:
> Included support for 25G/50G/100G speeds in supported/
> advertised speed modes
> Review comments from Ben Hutchings:
> Split the sff-8024 reorganzing patch and QSFP+/QSFP28
> patch
> Fixed all checkpatch warnings (except couple of over 80 character)
>
> v1:
> Support for SFF-8636 Rev 2.7
> Review comments from Ben Hutchings:
> Updating copyright holders information for QSFP
> Reusing the common functions and macros across sfpid and qsfp
>
> Vidya Sagar Ravipati (4):
> ethtool-copy.h:sync with net
> ethtool:Reorganizing SFF-8024 fields for SFP/QSFP
> ethtool:QSFP Plus/QSFP28 Diagnostics Information Support
> ethtool: Enhancing link mode bits to support 25G/50G/100G
>
> Makefile.am | 2 +-
> ethtool-copy.h | 18 +-
> ethtool.c | 35 +++
> internal.h | 3 +
> qsfp.c | 788 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> qsfp.h | 595 +++++++++++++++++++++++++++++++++++++++++++
> sff-common.c | 304 ++++++++++++++++++++++
> sff-common.h | 189 ++++++++++++++
> sfpdiag.c | 105 +-------
> sfpid.c | 103 +-------
> 10 files changed, 1945 insertions(+), 197 deletions(-)
> create mode 100644 qsfp.c
> create mode 100644 qsfp.h
> create mode 100644 sff-common.c
> create mode 100644 sff-common.h
>
> --
> 2.1.4
>
>
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [ethtool PATCH v4 0/4] Add support for QSFP+/QSFP28 Diagnostics and 25G/50G/100G port speeds
2016-08-24 14:33 ` John W. Linville
@ 2016-08-24 20:01 ` John W. Linville
0 siblings, 0 replies; 6+ messages in thread
From: John W. Linville @ 2016-08-24 20:01 UTC (permalink / raw)
To: Yuval Mintz
Cc: Vidya Sagar Ravipati, netdev, David Miller, decot@googlers.com,
bkenward@solarflare.com, daniel@iogearbox.net, galp@mellanox.com,
roopa@cumulusnetworks.com, gospo@cumulusnetworks.com,
dustin@cumulusnetworks.com, ben@decadent.org.uk
On Wed, Aug 24, 2016 at 10:33:04AM -0400, John W. Linville wrote:
> On Wed, Aug 24, 2016 at 04:29:22AM +0000, Yuval Mintz wrote:
> > > This patch series provides following support
> > > a) Reorganized fields based out of SFF-8024 fields i.e. Identifier/
> > > Encoding/Connector types which are common across SFP/SFP+ (SFF-8472)
> > > and QSFP+/QSFP28 (SFF-8436/SFF-8636) modules into sff-common files.
> > > b) Support for diagnostics information for QSFP Plus/QSFP28 modules
> > > based on SFF-8436/SFF-8636
> > > c) Supporting 25G/50G/100G speeds in supported/advertising fields
> > > d) Tested across various QSFP+/QSFP28 Copper/Optical modules
> > >
> > > Standards for QSFP+/QSFP28
> > > a) QSFP+/QSFP28 - SFF 8636 Rev 2.7 dated January 26,2016
> > > b) SFF-8024 Rev 4.0 dated May 31, 2016
> > >
> > > v4:
> > > Sync ethtool-copy.h to kernel commit
> > > 89da45b8b5b2187734a11038b8593714f964ffd1
> > > which includes support for 50G base SR2
> >
> > What about the man-page?
>
> I can just apply your man page patch on top.
And, I did.
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [ethtool PATCH v4 0/4] Add support for QSFP+/QSFP28 Diagnostics and 25G/50G/100G port speeds
2016-08-24 20:01 ` John W. Linville
@ 2016-08-24 20:39 ` Vidya Sagar Ravipati
0 siblings, 0 replies; 6+ messages in thread
From: Vidya Sagar Ravipati @ 2016-08-24 20:39 UTC (permalink / raw)
To: John W. Linville
Cc: netdev, David Miller, David Decotigny, bkenward, daniel,
Gal Pressman, Roopa Prabhu, Andy Gospodarek, Dustin Byford,
Ben Hutchings
On Wed, Aug 24, 2016 at 1:01 PM, John W. Linville
<linville@tuxdriver.com> wrote:
> I have pushed this series. I did modify patches 3 and 4 a bit,
> to properly update Makefile.am in order to keep "make distcheck"
> from failing -- please be more careful in the future.
>
Thanks for pushing the patches. Not aware of "make distcheck" and
will be careful going forward.
Quickly validated the build on SFP+/QSFP+/QSFP28 and everything seems fine
> John
>
> P.S. I have not yet tagged this as an official release, so please test!
>
> On Tue, Aug 23, 2016 at 06:30:29AM -0700, Vidya Sagar Ravipati wrote:
>> From: Vidya Sagar Ravipati <vidya@cumulusnetworks.com>
>>
>> This patch seryies provides following support
>> a) Reorganized fields based out of SFF-8024 fields i.e. Identifier/
>> Encoding/Connector types which are common across SFP/SFP+ (SFF-8472)
>> and QSFP+/QSFP28 (SFF-8436/SFF-8636) modules into sff-common files.
>> b) Support for diagnostics information for QSFP Plus/QSFP28 modules
>> based on SFF-8436/SFF-8636
>> c) Supporting 25G/50G/100G speeds in supported/advertising fields
>> d) Tested across various QSFP+/QSFP28 Copper/Optical modules
>>
>> Standards for QSFP+/QSFP28
>> a) QSFP+/QSFP28 - SFF 8636 Rev 2.7 dated January 26,2016
>> b) SFF-8024 Rev 4.0 dated May 31, 2016
>>
>> v4:
>> Sync ethtool-copy.h to kernel commit 89da45b8b5b2187734a11038b8593714f964ffd1
>> which includes support for 50G base SR2
>>
>> v3:
>> Review comments from Ben Hutchings:
>> Make sff diags structure common across sfpdiag.c and
>> qsfp.c and use common function to print common threshold
>> values.
>> Review comments from Rami Rosen:
>> Cleanup description messages.
>>
>> v2:
>> Included support for 25G/50G/100G speeds in supported/
>> advertised speed modes
>> Review comments from Ben Hutchings:
>> Split the sff-8024 reorganzing patch and QSFP+/QSFP28
>> patch
>> Fixed all checkpatch warnings (except couple of over 80 character)
>>
>> v1:
>> Support for SFF-8636 Rev 2.7
>> Review comments from Ben Hutchings:
>> Updating copyright holders information for QSFP
>> Reusing the common functions and macros across sfpid and qsfp
>>
>> Vidya Sagar Ravipati (4):
>> ethtool-copy.h:sync with net
>> ethtool:Reorganizing SFF-8024 fields for SFP/QSFP
>> ethtool:QSFP Plus/QSFP28 Diagnostics Information Support
>> ethtool: Enhancing link mode bits to support 25G/50G/100G
>>
>> Makefile.am | 2 +-
>> ethtool-copy.h | 18 +-
>> ethtool.c | 35 +++
>> internal.h | 3 +
>> qsfp.c | 788 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>> qsfp.h | 595 +++++++++++++++++++++++++++++++++++++++++++
>> sff-common.c | 304 ++++++++++++++++++++++
>> sff-common.h | 189 ++++++++++++++
>> sfpdiag.c | 105 +-------
>> sfpid.c | 103 +-------
>> 10 files changed, 1945 insertions(+), 197 deletions(-)
>> create mode 100644 qsfp.c
>> create mode 100644 qsfp.h
>> create mode 100644 sff-common.c
>> create mode 100644 sff-common.h
>>
>> --
>> 2.1.4
>>
>>
>
> --
> John W. Linville Someday the world will need a hero, and you
> linville@tuxdriver.com might be all we have. Be ready.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-08-24 20:56 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-23 13:30 [ethtool PATCH v4 0/4] Add support for QSFP+/QSFP28 Diagnostics and 25G/50G/100G port speeds Vidya Sagar Ravipati
2016-08-24 4:29 ` Yuval Mintz
2016-08-24 14:33 ` John W. Linville
2016-08-24 20:01 ` John W. Linville
2016-08-24 20:01 ` John W. Linville
2016-08-24 20:39 ` Vidya Sagar Ravipati
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).