From: David Miller <davem@redhat.com>
To: hariprasad@chelsio.com
Cc: netdev@vger.kernel.org, leedom@chelsio.com, nirranjan@chelsio.com
Subject: Re: [PATCH net-next 1/2] cxgb4/cxgb4vf: Add support for ndo_set_vf_vlan
Date: Thu, 25 Aug 2016 16:24:05 -0700 (PDT) [thread overview]
Message-ID: <20160825.162405.408460591169068270.davem@redhat.com> (raw)
In-Reply-To: <1472021434-8287-2-git-send-email-hariprasad@chelsio.com>
From: Hariprasad Shenai <hariprasad@chelsio.com>
Date: Wed, 24 Aug 2016 12:20:33 +0530
> + dev_info(pi->adapter->pdev_dev,
> + "Setting Vlan %u to VF [%d]\n", vlan, vf);
> + dev_info(pi->adapter->pdev_dev,
> + "The VF [%d] interface needs to brought down and up, "
> + "if VF is already up and running, for VST to work\n", vf);
Requiring the user to do something like this for the feature to work
correctly is not reasonable at all.
I want you to seriously consider rearchitecting this whole facility.
next prev parent reply other threads:[~2016-08-25 23:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-24 6:50 [PATCH net-next 0/2] cxgb4: Adds support for VF mgmt ndo's Hariprasad Shenai
2016-08-24 6:50 ` [PATCH net-next 1/2] cxgb4/cxgb4vf: Add support for ndo_set_vf_vlan Hariprasad Shenai
2016-08-24 7:08 ` Yuval Mintz
2016-08-24 8:22 ` Hariprasad Shenai
2016-08-24 8:31 ` Yuval Mintz
2016-08-24 9:40 ` Hariprasad Shenai
2016-08-24 10:02 ` Yuval Mintz
2016-08-25 23:24 ` David Miller [this message]
2016-08-24 6:50 ` [PATCH net-next 2/2] cxgb4: Add support for ndo_get_vf_config Hariprasad Shenai
2016-08-24 7:15 ` Yuval Mintz
2016-08-24 7:58 ` Hariprasad Shenai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160825.162405.408460591169068270.davem@redhat.com \
--to=davem@redhat.com \
--cc=hariprasad@chelsio.com \
--cc=leedom@chelsio.com \
--cc=netdev@vger.kernel.org \
--cc=nirranjan@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox