netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sabrina Dubroca <sd@queasysnail.net>
To: Owen Lin <olin@rivetnetworks.com>
Cc: "johannes@sipsolutions.net" <johannes@sipsolutions.net>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"edumazet@google.com" <edumazet@google.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH 1/1] net: add killer E2500 device id
Date: Thu, 25 Aug 2016 11:58:14 +0200	[thread overview]
Message-ID: <20160825095814.GA26023@bistromath.localdomain> (raw)
In-Reply-To: <BN3PR0401MB1457768A72BE42070D34E581C0ED0@BN3PR0401MB1457.namprd04.prod.outlook.com>

Hi Owen,

2016-08-25, 03:33:11 +0000, Owen Lin wrote:
> Add Killer E2500 device ID in alx driver.
> 
> Signed-off-by: Owen Lin olin@rivetnetworks.com
> 
> --------------------------------------------------------------------------------

This line shouldn't be here (it will end up in the commit message).


> diff -up1rN alx_orig/main.c alx/main.c
> --- alx_orig/main.c	2016-08-25 11:12:34.170447500 +0800
> +++ alx/main.c	2016-08-25 11:24:12.026853000 +0800

That patch won't apply.  The patch should be generated from the root
directory, and include the full path of the files you're modifying, so
that the patch can be applied from the root directory of the kernel
tree.  i.e. the paths should be of the form

    a/drivers/net/ethernet/atheros/alx/main.c

The easiest way to create patches that apply properly is to use the
git tree and the `git format-patch` tool.


Thanks,

-- 
Sabrina

  reply	other threads:[~2016-08-25 10:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-25  3:33 [PATCH 1/1] net: add killer E2500 device id Owen Lin
2016-08-25  9:58 ` Sabrina Dubroca [this message]
  -- strict thread matches above, loose matches on Subject: below --
2016-08-26  5:55 Owen Lin
2016-08-29  4:24 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160825095814.GA26023@bistromath.localdomain \
    --to=sd@queasysnail.net \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=johannes@sipsolutions.net \
    --cc=netdev@vger.kernel.org \
    --cc=olin@rivetnetworks.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).