From: David Miller <davem@davemloft.net>
To: colin.king@canonical.com
Cc: yisen.zhuang@huawei.com, salil.mehta@huawei.com,
lisheng011@huawei.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: hns: dereference ppe_cb->ppe_common_cb if it is non-null
Date: Fri, 26 Aug 2016 11:45:44 -0700 (PDT) [thread overview]
Message-ID: <20160826.114544.331469797150439600.davem@davemloft.net> (raw)
In-Reply-To: <20160825065110.10104-1-colin.king@canonical.com>
From: Colin King <colin.king@canonical.com>
Date: Thu, 25 Aug 2016 07:51:10 +0100
> From: Colin Ian King <colin.king@canonical.com>
>
> ppe_cb->ppe_common_cb is being dereferenced before a null check is
> being made on it. If ppe_cb->ppe_common_cb is null then we end up
> with a null pointer dereference when assigning dsaf_dev. Fix this
> by moving the initialisation of dsaf_dev once we know
> ppe_cb->ppe_common_cb is OK to dereference.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied.
prev parent reply other threads:[~2016-08-26 18:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-25 6:51 [PATCH] net: hns: dereference ppe_cb->ppe_common_cb if it is non-null Colin King
2016-08-26 0:42 ` Yisen Zhuang
2016-08-26 18:45 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160826.114544.331469797150439600.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=colin.king@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lisheng011@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=salil.mehta@huawei.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).