From: Jiri Benc <jbenc@redhat.com>
To: Shmulik Ladkani <shmulik.ladkani@gmail.com>
Cc: Hadar Hen Zion <hadarh@mellanox.com>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, Jiri Pirko <jiri@mellanox.com>,
Jamal Hadi Salim <jhs@mojatatu.com>,
Tom Herbert <tom@herbertland.com>,
Or Gerlitz <ogerlitz@mellanox.com>,
Amir Vadai <amirva@mellanox.com>, Amir Vadai <amir@vadai.me>
Subject: Re: [PATCH net-next V3 2/4] net/dst: Utility functions to build dst_metadata without supplying an skb
Date: Fri, 26 Aug 2016 12:31:59 +0200 [thread overview]
Message-ID: <20160826123159.5f525fc2@griffin> (raw)
In-Reply-To: <20160825194050.262ddb5f@halley>
On Thu, 25 Aug 2016 19:40:50 +0300, Shmulik Ladkani wrote:
> On Thu, 25 Aug 2016 19:13:45 +0300 Hadar Hen Zion <hadarh@mellanox.com> wrote:
> > From: Amir Vadai <amir@vadai.me>
> >
> > Extract _ip_tun_rx_dst() and _ipv6_tun_rx_dst() out of ip_tun_rx_dst()
> > and ipv6_tun_rx_dst(), to be used without supplying an skb.
>
> Per this v3, the newly introduced helpers ate named _ip_tun_set_dst and
> _ipv6_tun_set_dst - better alter the log message to reflect that.
And please rename them to start with double underscore to match the
coding style of the rest of the kernel.
Thanks!
Jiri
next prev parent reply other threads:[~2016-08-26 10:38 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-25 16:13 [PATCH net-next V3 0/4] net/sched: ip tunnel metadata set/release/classify by using TC Hadar Hen Zion
2016-08-25 16:13 ` [PATCH net-next V3 1/4] net/ip_tunnels: Introduce tunnel_id_to_key32() and key32_to_tunnel_id() Hadar Hen Zion
2016-08-26 10:26 ` Jiri Benc
2016-08-25 16:13 ` [PATCH net-next V3 2/4] net/dst: Utility functions to build dst_metadata without supplying an skb Hadar Hen Zion
2016-08-25 16:40 ` Shmulik Ladkani
2016-08-26 6:14 ` Or Gerlitz
2016-08-26 10:31 ` Jiri Benc [this message]
2016-08-25 16:13 ` [PATCH net-next V3 3/4] net/sched: cls_flower: Classify packet in ip tunnels Hadar Hen Zion
2016-08-26 10:46 ` Jiri Benc
2016-08-25 16:13 ` [PATCH net-next V3 4/4] net/sched: Introduce act_tunnel_key Hadar Hen Zion
2016-08-25 16:52 ` Shmulik Ladkani
2016-08-25 17:48 ` Eric Dumazet
2016-08-26 6:16 ` Or Gerlitz
2016-08-26 18:26 ` Cong Wang
2016-08-26 19:16 ` Eric Dumazet
2016-08-29 5:04 ` Cong Wang
2016-08-30 11:03 ` Amir Vadai
2016-08-30 11:39 ` Amir Vadai
2016-08-30 12:27 ` Eric Dumazet
2016-08-30 12:05 ` Jamal Hadi Salim
2016-08-30 13:17 ` Amir Vadai
2016-08-30 14:27 ` Eric Dumazet
2016-08-26 11:13 ` Jiri Benc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160826123159.5f525fc2@griffin \
--to=jbenc@redhat.com \
--cc=amir@vadai.me \
--cc=amirva@mellanox.com \
--cc=davem@davemloft.net \
--cc=hadarh@mellanox.com \
--cc=jhs@mojatatu.com \
--cc=jiri@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=shmulik.ladkani@gmail.com \
--cc=tom@herbertland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).