netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Shmulik Ladkani <shmulik.ladkani@gmail.com>
To: Alexander Duyck <alexander.duyck@gmail.com>
Cc: Steffen Klassert <steffen.klassert@secunet.com>,
	Netdev <netdev@vger.kernel.org>,
	Eric Dumazet <eric.dumazet@gmail.com>,
	Alexander Duyck <alexander.h.duyck@intel.com>,
	Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Subject: Re: [PATCH net-next v1] gso: Support partial splitting at the frag_list pointer
Date: Sat, 27 Aug 2016 10:47:11 +0300	[thread overview]
Message-ID: <20160827104711.46f73c12@halley> (raw)
In-Reply-To: <CAKgT0UcYLrx1PzKo6Lw-rHGOj-1wMO2dP-93Brs7EGY-OFR4Gw@mail.gmail.com>

Hi,

On Fri, 26 Aug 2016 13:45:56 -0700 Alexander Duyck <alexander.duyck@gmail.com> wrote:
> > However, if TSO is off, but GSO is on, who takes care of further
> > splitting these skbs according to their gso_size?  
> 
> I believe the patch resolves it via the net_gso_ok check.  This is
> used to verify if the lower device could segment it if we split out
> the buffers from skb->frag_list.

Thanks, got it.

> > And another question:
> > Can this be utilized in any way to solve the problem described in [1] ?
> >
> > [1] https://patchwork.ozlabs.org/patch/661419/  
> 
> I don't think so.  This solution is to only do part of the software
> offload and still make use of an existing hardware offload.

Sorry, I wasn't too clear.

When attempting to reduce gso_size in order to avoid
segmentation+fragmentation, problem I'm hitting is:
  http://lists.openwall.net/netdev/2016/08/25/35

Actually, the idea of yours hinted me to a new direction, will pursue
that.

Thanks,
Shmulik

  reply	other threads:[~2016-08-27  8:02 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-23  5:20 [PATCH net-next v1] gso: Support partial splitting at the frag_list pointer Steffen Klassert
2016-08-23 14:47 ` Alexander Duyck
2016-08-24  9:32   ` Steffen Klassert
2016-08-24 16:27     ` Alexander Duyck
2016-08-24 17:25       ` Marcelo Ricardo Leitner
2016-08-25  7:31         ` Steffen Klassert
2016-08-25 12:17           ` Marcelo Ricardo Leitner
2016-08-29 12:02             ` Steffen Klassert
2016-08-25 11:00       ` Steffen Klassert
2016-08-25 12:38         ` Marcelo Ricardo Leitner
2016-08-25 16:02         ` Alexander Duyck
2016-08-29 12:00           ` Steffen Klassert
2016-08-26 20:36         ` Shmulik Ladkani
2016-08-26 20:45           ` Alexander Duyck
2016-08-27  7:47             ` Shmulik Ladkani [this message]
2016-08-26 20:59         ` Alexander Duyck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160827104711.46f73c12@halley \
    --to=shmulik.ladkani@gmail.com \
    --cc=alexander.duyck@gmail.com \
    --cc=alexander.h.duyck@intel.com \
    --cc=eric.dumazet@gmail.com \
    --cc=marcelo.leitner@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=steffen.klassert@secunet.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).