From: David Miller <davem@davemloft.net>
To: tom@herbertland.com
Cc: netdev@vger.kernel.org, kernel-team@fb.com, davejwatson@fb.com
Subject: Re: [PATCH net-next 0/3] strp: Generalize stream parser to work with other socket types
Date: Sun, 28 Aug 2016 23:34:50 -0400 (EDT) [thread overview]
Message-ID: <20160828.233450.783176953748442286.davem@davemloft.net> (raw)
In-Reply-To: <1472420599-510735-1-git-send-email-tom@herbertland.com>
From: Tom Herbert <tom@herbertland.com>
Date: Sun, 28 Aug 2016 14:43:16 -0700
> Add a read_sock protocol operation function that allows something like
> tcp_read_sock to be called for other protocol types.
>
> Specific changes in this patch set:
> - Add read_sock function to proto_ops. This has the same signature as
> tcp_read_sock. sk_read_actor_t is also defined in net.h.
> - Set peek_len and read_sock proto_op functions for TCPv4 and TCPv6
> stream ops.
> - Remove references to tcp in strparser.
> - Call peek_len and read_sock operations from strparser instead of
> calling TCP specific functions.
I'll apply this, but I want you to shore up these new ops.
A check has to happen somewhere to make sure the proto_ops in
question have a non-NULL read_sock and peek_len method before
starting to use it.
next prev parent reply other threads:[~2016-08-29 3:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-28 21:43 [PATCH net-next 0/3] strp: Generalize stream parser to work with other socket types Tom Herbert
2016-08-28 21:43 ` [PATCH net-next 1/3] net: Add read_sock proto_op Tom Herbert
2016-08-28 21:43 ` [PATCH net-next 2/3] tcp: Set read_sock and peek_len proto_ops Tom Herbert
2016-08-28 21:43 ` [PATCH net-next 3/3] kcm: Remove TCP specific references from kcm and strparser Tom Herbert
2016-08-29 3:34 ` David Miller [this message]
2016-08-29 15:52 ` [PATCH net-next 0/3] strp: Generalize stream parser to work with other socket types Tom Herbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160828.233450.783176953748442286.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=davejwatson@fb.com \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
--cc=tom@herbertland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).