From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [patch iproute2 1/2] tc: Add support for the matchall traffic classifier. Date: Mon, 29 Aug 2016 11:03:21 -0700 Message-ID: <20160829110321.78959dc8@xeon-e3> References: <1471866986-3156-1-git-send-email-jiri@resnulli.us> <1471866986-3156-2-git-send-email-jiri@resnulli.us> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, yotamg@mellanox.com, eladr@mellanox.com, idosch@mellanox.com, nogahf@mellanox.com, ogerlitz@mellanox.com To: Jiri Pirko Return-path: Received: from mail-pf0-f169.google.com ([209.85.192.169]:33987 "EHLO mail-pf0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755303AbcH2SDK (ORCPT ); Mon, 29 Aug 2016 14:03:10 -0400 Received: by mail-pf0-f169.google.com with SMTP id p64so54416659pfb.1 for ; Mon, 29 Aug 2016 11:03:10 -0700 (PDT) In-Reply-To: <1471866986-3156-2-git-send-email-jiri@resnulli.us> Sender: netdev-owner@vger.kernel.org List-ID: On Mon, 22 Aug 2016 13:56:25 +0200 Jiri Pirko wrote: > From: Yotam Gigi > > The matchall classifier matches every packet and allows the user to apply > actions on it. In addition, it supports the skip_sw and skip_hw (as can > be found on u32 and flower filter) that direct the kernel to skip the > software/hardware processing of the actions. > > This filter is very useful in usecases where every packet should be > matched. For example, packet mirroring (SPAN) can be setup very easily > using that filter. > > Signed-off-by: Yotam Gigi > Signed-off-by: Jiri Pirko I am not a checkpatch purist, but these two should be addressed. WARNING: unnecessary whitespace before a quoted newline #81: FILE: tc/f_matchall.c:29: + fprintf(stderr, "Usage: ... matchall [skip_sw | skip_hw] \n"); WARNING: braces {} are not necessary for single statement blocks #185: FILE: tc/f_matchall.c:133: + if (tb[TCA_MATCHALL_ACT]) { + tc_print_action(f, tb[TCA_MATCHALL_ACT]); + }