From: Stephen Hemminger <stephen@networkplumber.org>
To: Hadar Hen Zion <hadarh@mellanox.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Jiri Pirko <jiri@mellanox.com>, Amir Vadai <amirva@mellanox.com>,
Or Gerlitz <ogerlitz@mellanox.com>
Subject: Re: [PATCH iproute2 1/2] tc: flower: Introduce vlan support
Date: Mon, 29 Aug 2016 11:14:10 -0700 [thread overview]
Message-ID: <20160829111410.1a23a4bc@xeon-e3> (raw)
In-Reply-To: <1471861494-8299-2-git-send-email-hadarh@mellanox.com>
On Mon, 22 Aug 2016 13:24:53 +0300
Hadar Hen Zion <hadarh@mellanox.com> wrote:
> iff --git a/include/linux/tc_act/tc_vlan.h b/include/linux/tc_act/tc_vlan.h
> index 31151ff..26ae695 100644
> --- a/include/linux/tc_act/tc_vlan.h
> +++ b/include/linux/tc_act/tc_vlan.h
> @@ -16,6 +16,9 @@
>
> #define TCA_VLAN_ACT_POP 1
> #define TCA_VLAN_ACT_PUSH 2
> +#define VLAN_PRIO_MASK 0x7
> +#define VLAN_VID_MASK 0x0fff
> +
>
> struct tc_vlan {
> tc_gen;
I was going to apply this, it looks fine. But there is an issue
you need to address first.
All headers in iproute2 come from sanitized version of the kernel headers.
This header does not match the version in net-next.
net-next$ grep VLAN_PRIO_MASK usr/include/linux/tc_act/tc_vlan.h
Please update the kernel header first, then resubmit the patch.
next prev parent reply other threads:[~2016-08-29 18:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-22 10:24 [PATCH iproute2 0/2] tc: flower, m_vlan: Introduce vlan tag support Hadar Hen Zion
2016-08-22 10:24 ` [PATCH iproute2 1/2] tc: flower: Introduce vlan support Hadar Hen Zion
2016-08-22 11:06 ` Jiri Pirko
2016-08-29 18:14 ` Stephen Hemminger [this message]
2016-08-22 10:24 ` [PATCH iproute2 2/2] tc: m_vlan: Add priority option to push vlan action Hadar Hen Zion
2016-08-22 11:07 ` Jiri Pirko
[not found] <1471860867-7836-1-git-send-email-y>
2016-08-22 10:14 ` [PATCH iproute2 1/2] tc: flower: Introduce vlan support y
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160829111410.1a23a4bc@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=amirva@mellanox.com \
--cc=davem@davemloft.net \
--cc=hadarh@mellanox.com \
--cc=jiri@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).