From: Stephen Hemminger <stephen@networkplumber.org>
To: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Cc: netdev@vger.kernel.org, roopa@cumulusnetworks.com,
davem@davemloft.net, bridge@lists.linux-foundation.org
Subject: Re: [PATCH net-next 1/2] net: bridge: change unicast boolean to exact pkt_type
Date: Tue, 30 Aug 2016 07:56:23 -0700 [thread overview]
Message-ID: <20160830075623.15af2674@xeon-e3> (raw)
In-Reply-To: <1472562539-23247-2-git-send-email-nikolay@cumulusnetworks.com>
On Tue, 30 Aug 2016 15:08:58 +0200
Nikolay Aleksandrov <nikolay@cumulusnetworks.com> wrote:
> /* br_forward.c */
> +enum {
> + BR_PKT_UNICAST,
> + BR_PKT_MULTICAST,
> + BR_PKT_BROADCAST
> +};
> int br_dev_queue_push_xmit(struct net *net, struct sock *sk, struct sk_buff *skb);
> void br_forward(const struct net_bridge_port *to, struct sk_buff *skb,
> bool local_rcv, bool local_orig);
> int br_forward_finish(struct net *net, struct sock *sk, struct sk_buff *skb);
> void br_flood(struct net_bridge *br, struct sk_buff *skb,
> - bool unicast, bool local_rcv, bool local_orig);
> + int pkt_type, bool local_rcv, bool local_orig);
Why not make pkt_type an enum value, you already have that infrastructure there.
enum br_pkt_type {
BR_PKT_UNICAST,
...
};
void br_flood(struct net_bridge *br, struct sk_buff *skb,
enum br_pkt_type pkt_type, ...
next prev parent reply other threads:[~2016-08-30 14:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-30 13:08 [PATCH net-next 0/2] net: bridge: add per-port unknown multicast flood control Nikolay Aleksandrov via Bridge
2016-08-30 13:08 ` [PATCH net-next 1/2] net: bridge: change unicast boolean to exact pkt_type Nikolay Aleksandrov
2016-08-30 14:56 ` Stephen Hemminger [this message]
2016-08-30 14:57 ` Nikolay Aleksandrov via Bridge
2016-08-30 14:59 ` Stephen Hemminger
2016-08-30 15:00 ` Nikolay Aleksandrov
2016-08-30 15:10 ` Nikolay Aleksandrov via Bridge
2016-08-30 13:08 ` [PATCH net-next 2/2] net: bridge: add per-port multicast flood flag Nikolay Aleksandrov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160830075623.15af2674@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=roopa@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox