From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH net-next 1/2] net: bridge: change unicast
 boolean to exact pkt_type
Date: Tue, 30 Aug 2016 07:56:23 -0700
Message-ID: <20160830075623.15af2674@xeon-e3>
References: <1472562539-23247-1-git-send-email-nikolay@cumulusnetworks.com>
	<1472562539-23247-2-git-send-email-nikolay@cumulusnetworks.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org, roopa@cumulusnetworks.com, davem@davemloft.net,
	bridge@lists.linux-foundation.org
To: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Return-path: <bridge-bounces@lists.linux-foundation.org>
In-Reply-To: <1472562539-23247-2-git-send-email-nikolay@cumulusnetworks.com>
List-Unsubscribe: <https://lists.linuxfoundation.org/mailman/options/bridge>,
	<mailto:bridge-request@lists.linux-foundation.org?subject=unsubscribe>
List-Archive: <http://lists.linuxfoundation.org/pipermail/bridge/>
List-Post: <mailto:bridge@lists.linux-foundation.org>
List-Help: <mailto:bridge-request@lists.linux-foundation.org?subject=help>
List-Subscribe: <https://lists.linuxfoundation.org/mailman/listinfo/bridge>,
	<mailto:bridge-request@lists.linux-foundation.org?subject=subscribe>
Sender: bridge-bounces@lists.linux-foundation.org
Errors-To: bridge-bounces@lists.linux-foundation.org
List-Id: netdev.vger.kernel.org

On Tue, 30 Aug 2016 15:08:58 +0200
Nikolay Aleksandrov <nikolay@cumulusnetworks.com> wrote:

>  /* br_forward.c */
> +enum {
> +	BR_PKT_UNICAST,
> +	BR_PKT_MULTICAST,
> +	BR_PKT_BROADCAST
> +};
>  int br_dev_queue_push_xmit(struct net *net, struct sock *sk, struct sk_buff *skb);
>  void br_forward(const struct net_bridge_port *to, struct sk_buff *skb,
>  		bool local_rcv, bool local_orig);
>  int br_forward_finish(struct net *net, struct sock *sk, struct sk_buff *skb);
>  void br_flood(struct net_bridge *br, struct sk_buff *skb,
> -	      bool unicast, bool local_rcv, bool local_orig);
> +	      int pkt_type, bool local_rcv, bool local_orig);

Why not make pkt_type an enum value, you already have that infrastructure there.

enum br_pkt_type {
	BR_PKT_UNICAST,
...
};

void br_flood(struct net_bridge *br, struct sk_buff *skb,
              enum br_pkt_type pkt_type, ...