From: David Miller <davem@davemloft.net>
To: stephen@networkplumber.org
Cc: Julia.Lawall@lip6.fr, thomas.lendacky@amd.com, netdev@vger.kernel.org
Subject: Re: [RFC] xgbe: constify get_netdev_ops and get_ethtool_ops
Date: Wed, 31 Aug 2016 14:17:50 -0700 (PDT) [thread overview]
Message-ID: <20160831.141750.55012883444641424.davem@davemloft.net> (raw)
In-Reply-To: <20160831085736.29fc6512@xeon-e3>
From: Stephen Hemminger <stephen@networkplumber.org>
Date: Wed, 31 Aug 2016 08:57:36 -0700
> Casting away const is bad practice. Since this is ARM specific driver
> don't have hardware actually test this.
>
> Having getter functions for ops is really unnecessary code bloat, but
> not going to touch that.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
I'll just apply this, let's see what happens.
next prev parent reply other threads:[~2016-08-31 21:17 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-31 7:30 [PATCH 0/6] constify ethtool_ops structures Julia Lawall
2016-08-31 7:30 ` [PATCH 2/6] net: ethernet: et131x: " Julia Lawall
2016-08-31 11:48 ` Mark Einon
2016-08-31 7:30 ` [PATCH 3/6] net: bcmgenet: " Julia Lawall
2016-08-31 17:08 ` Florian Fainelli
2016-08-31 7:30 ` [PATCH 4/6] net: hisilicon: " Julia Lawall
2016-08-31 7:30 ` [PATCH 5/6] dwc_eth_qos: " Julia Lawall
2016-08-31 7:30 ` [PATCH 6/6] net: systemport: " Julia Lawall
2016-08-31 17:08 ` Florian Fainelli
2016-08-31 15:39 ` [PATCH 0/6] " Stephen Hemminger
2016-08-31 19:40 ` Julia Lawall
2016-08-31 15:57 ` [RFC] xgbe: constify get_netdev_ops and get_ethtool_ops Stephen Hemminger
2016-08-31 21:17 ` David Miller [this message]
2016-09-01 0:50 ` Tom Lendacky
2016-09-01 17:45 ` Tom Lendacky
2016-08-31 16:22 ` [PATCH 0/6] constify ethtool_ops structures David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160831.141750.55012883444641424.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Julia.Lawall@lip6.fr \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=thomas.lendacky@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).