From: David Miller <davem@davemloft.net>
To: elicooper@gmx.com
Cc: netdev@vger.kernel.org, sergei.shtylyov@cogentembedded.com
Subject: Re: [PATCH v2] ipv6: Use inbound ifaddr as source addresses for ICMPv6 errors
Date: Wed, 31 Aug 2016 20:59:06 -0700 (PDT) [thread overview]
Message-ID: <20160831.205906.751461157991798139.davem@davemloft.net> (raw)
In-Reply-To: <20160828033406.11269-1-elicooper@gmx.com>
From: Eli Cooper <elicooper@gmx.com>
Date: Sun, 28 Aug 2016 11:34:06 +0800
> According to RFC 1885 2.2(c), the source address of ICMPv6
> errors in response to forwarded packets should be set to the
> unicast address of the forwarding interface in order to be helpful
> in diagnosis. Currently the selection of source address is based
> on the default route, without respect to the inbound interface.
>
> This patch sets the source address of ICMPv6 error messages to
> the address of inbound interface, with the exception of
> 'time exceeded' and 'packet to big' messages sent in ip6_forward(),
> where the address of OUTPUT device is forced as source address
> (however, it is NOT enforced as claimed without this patch).
>
> Signed-off-by: Eli Cooper <elicooper@gmx.com>
Please resubmit with an updated commit message describing
the use case.
prev parent reply other threads:[~2016-09-01 3:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-28 3:34 [PATCH v2] ipv6: Use inbound ifaddr as source addresses for ICMPv6 errors Eli Cooper
2016-08-28 17:18 ` Guillaume Nault
2016-08-28 18:34 ` Eli Cooper
2016-08-30 19:51 ` Guillaume Nault
2016-09-01 3:59 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160831.205906.751461157991798139.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=elicooper@gmx.com \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).