From: David Miller <davem@davemloft.net>
To: Yuval.Mintz@qlogic.com
Cc: fengguang.wu@intel.com, kbuild-all@01.org,
netdev@vger.kernel.org, Ariel.Elior@qlogic.com,
Dept-EngEverestLinuxL2@qlogic.com, linux-kernel@vger.kernel.org,
Sudarsana.Kalluru@qlogic.com
Subject: Re: [PATCH] qed: fix kzalloc-simple.cocci warnings
Date: Thu, 01 Sep 2016 09:48:13 -0700 (PDT) [thread overview]
Message-ID: <20160901.094813.947883991894136945.davem@davemloft.net> (raw)
In-Reply-To: <DM5PR11MB1723927908802E0D1C38C94D97E20@DM5PR11MB1723.namprd11.prod.outlook.com>
From: Yuval Mintz <Yuval.Mintz@qlogic.com>
Date: Thu, 1 Sep 2016 07:37:13 +0000
>> drivers/net/ethernet/qlogic/qed/qed_dcbx.c:1230:13-20: WARNING: kzalloc
>> should be used for dcbx_info, instead of kmalloc/memset
>> drivers/net/ethernet/qlogic/qed/qed_dcbx.c:1192:13-20: WARNING: kzalloc
>> should be used for dcbx_info, instead of kmalloc/memset
>>
>>
>> Use kzalloc rather than kmalloc followed by memset with 0
>>
>> This considers some simple cases that are common and easy to validate Note in
>> particular that there are no ...s in the rule, so all of the matched code has to be
>> contiguous
>>
>> Generated by: scripts/coccinelle/api/alloc/kzalloc-simple.cocci
>>
>> CC: Sudarsana Reddy Kalluru <sudarsana.kalluru@qlogic.com>
>> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
>
> This looks fine; But what's the right process here -
> Dave - do we need to re-post this with the the right 'destination' in title
> [net/net-next]? Or is it good as-is?
> In case of latter,
> Acked-by: Yuval Mintz <Yuval.Mintz@qlogic.com>
I'll apply this as-is, thanks.
next prev parent reply other threads:[~2016-09-01 16:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-01 6:45 [net:master 27/28] drivers/net/ethernet/qlogic/qed/qed_dcbx.c:1230:13-20: WARNING: kzalloc should be used for dcbx_info, instead of kmalloc/memset kbuild test robot
2016-09-01 6:45 ` [PATCH] qed: fix kzalloc-simple.cocci warnings kbuild test robot
2016-09-01 7:37 ` Yuval Mintz
2016-09-01 16:48 ` David Miller [this message]
2016-09-02 17:44 ` Joe Perches
2016-09-02 17:48 ` [PATCH] qed: Remove OOM messages Joe Perches
2016-09-04 8:18 ` Yuval Mintz
2016-09-04 20:28 ` David Miller
2016-09-04 21:22 ` Joe Perches
-- strict thread matches above, loose matches on Subject: below --
2017-04-21 0:20 [net:master 15/18] drivers/net/ethernet/qlogic/qed/qed_dcbx.c:1267:13-20: WARNING: kzalloc should be used for dcbx_info, instead of kmalloc/memset kbuild test robot
2017-04-21 0:20 ` [PATCH] qed: fix kzalloc-simple.cocci warnings kbuild test robot
2017-04-24 16:03 ` David Miller
[not found] <201509302130.SXWHwgAF%fengguang.wu@intel.com>
2015-09-30 13:03 ` [RFC v3 net-next 01/10] qed: Add module with basic common support Yuval Mintz
2015-09-30 13:33 ` [PATCH] qed: fix kzalloc-simple.cocci warnings kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160901.094813.947883991894136945.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Ariel.Elior@qlogic.com \
--cc=Dept-EngEverestLinuxL2@qlogic.com \
--cc=Sudarsana.Kalluru@qlogic.com \
--cc=Yuval.Mintz@qlogic.com \
--cc=fengguang.wu@intel.com \
--cc=kbuild-all@01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).