From: David Miller <davem@davemloft.net>
To: ivecera@redhat.com
Cc: netdev@vger.kernel.org, satish.baddipadige@broadcom.com,
siva.kallam@broadcom.com, michael.chan@broadcom.com
Subject: Re: [PATCH net v2] tg3: Fix for disallow tx coalescing time to be 0
Date: Thu, 01 Sep 2016 09:58:09 -0700 (PDT) [thread overview]
Message-ID: <20160901.095809.1791445078754790512.davem@davemloft.net> (raw)
In-Reply-To: <1472722139-22806-1-git-send-email-ivecera@redhat.com>
From: Ivan Vecera <ivecera@redhat.com>
Date: Thu, 1 Sep 2016 11:28:59 +0200
> The recent commit 087d7a8c9174 "tg3: Fix for diasllow rx coalescing
> time to be 0" disallow to set Rx coalescing time to be 0 as this stops
> generating interrupts for the incoming packets. I found the zero
> Tx coalescing time stops generating interrupts for outgoing packets
> as well and fires Tx watchdog later. To avoid this, don't allow to set
> Tx coalescing time to 0 and also remove subsequent checks that become
> senseless.
>
> Cc: satish.baddipadige@broadcom.com
> Cc: siva.kallam@broadcom.com
> Cc: michael.chan@broadcom.com
> Signed-off-by: Ivan Vecera <ivecera@redhat.com>
Applied.
next prev parent reply other threads:[~2016-09-01 20:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-01 9:28 [PATCH net v2] tg3: Fix for disallow tx coalescing time to be 0 Ivan Vecera
2016-09-01 14:39 ` Michael Chan
2016-09-01 16:58 ` David Miller [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-09-01 9:38 Siva Reddy Kallam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160901.095809.1791445078754790512.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ivecera@redhat.com \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=satish.baddipadige@broadcom.com \
--cc=siva.kallam@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).