* [PATCH net-next] sky2: use napi_complete_done
@ 2016-08-29 17:16 Stephen Hemminger
2016-08-29 18:35 ` Eric Dumazet
2016-09-01 21:10 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Stephen Hemminger @ 2016-08-29 17:16 UTC (permalink / raw)
To: Mirko Lindner, David Miller; +Cc: netdev
Update the sky2 driver to pass number of packets done to NAPI.
The driver was never updated when napi_complete_done was added.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
drivers/net/ethernet/marvell/sky2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/marvell/sky2.c b/drivers/net/ethernet/marvell/sky2.c
index 467138b..f05ea56 100644
--- a/drivers/net/ethernet/marvell/sky2.c
+++ b/drivers/net/ethernet/marvell/sky2.c
@@ -3070,7 +3070,7 @@ static int sky2_poll(struct napi_struct *napi, int work_limit)
goto done;
}
- napi_complete(napi);
+ napi_complete_done(napi, work_done);
sky2_read32(hw, B0_Y2_SP_LISR);
done:
--
2.9.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] sky2: use napi_complete_done
2016-08-29 17:16 [PATCH net-next] sky2: use napi_complete_done Stephen Hemminger
@ 2016-08-29 18:35 ` Eric Dumazet
2016-09-01 21:10 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Eric Dumazet @ 2016-08-29 18:35 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: Mirko Lindner, David Miller, netdev
On Mon, 2016-08-29 at 10:16 -0700, Stephen Hemminger wrote:
> Update the sky2 driver to pass number of packets done to NAPI.
> The driver was never updated when napi_complete_done was added.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
Acked-by: Eric Dumazet <edumazet@google.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] sky2: use napi_complete_done
2016-08-29 17:16 [PATCH net-next] sky2: use napi_complete_done Stephen Hemminger
2016-08-29 18:35 ` Eric Dumazet
@ 2016-09-01 21:10 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2016-09-01 21:10 UTC (permalink / raw)
To: stephen; +Cc: mlindner, netdev
From: Stephen Hemminger <stephen@networkplumber.org>
Date: Mon, 29 Aug 2016 10:16:37 -0700
> Update the sky2 driver to pass number of packets done to NAPI.
> The driver was never updated when napi_complete_done was added.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Applied, thanks Stephen.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-09-01 21:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-29 17:16 [PATCH net-next] sky2: use napi_complete_done Stephen Hemminger
2016-08-29 18:35 ` Eric Dumazet
2016-09-01 21:10 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).