From: David Miller <davem@davemloft.net>
To: jeffrey.t.kirsher@intel.com
Cc: david.m.ertman@intel.com, netdev@vger.kernel.org,
nhorman@redhat.com, sassmann@redhat.com, jogreene@redhat.com,
guru.anbalagane@oracle.com
Subject: Re: [net] i40e: Fix kernel panic on enable/disable LLDP
Date: Thu, 01 Sep 2016 14:20:45 -0700 (PDT) [thread overview]
Message-ID: <20160901.142045.1724169627272941166.davem@davemloft.net> (raw)
In-Reply-To: <1472517506-74650-1-git-send-email-jeffrey.t.kirsher@intel.com>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Mon, 29 Aug 2016 17:38:26 -0700
> From: Dave Ertman <david.m.ertman@intel.com>
>
> If DCB is configured on the link partner switch with an
> unsupported traffic class configuration (e.g. non-contiguous TCs),
> the driver is flagging DCB as disabled. But, for future DCB
> LLDPDUs, the driver was checking if the interface was DCB capable
> instead of enabled. This was causing a kernel panic when LLDP
> was enabled/disabled on the link partner switch.
>
> This patch corrects the situation by having the LLDP event handler
> check the correct flag in the pf structure. It also cleans up the
> setting and clearing of the enabled flag for other checks.
>
> Signed-off-by: Dave Ertman <david.m.ertman@intel.com>
> Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Applied, thanks Jeff.
prev parent reply other threads:[~2016-09-01 21:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-30 0:38 [net] i40e: Fix kernel panic on enable/disable LLDP Jeff Kirsher
2016-09-01 21:20 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160901.142045.1724169627272941166.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=david.m.ertman@intel.com \
--cc=guru.anbalagane@oracle.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jogreene@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@redhat.com \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).