From: David Miller <davem@davemloft.net>
To: ncardwell@google.com
Cc: netdev@vger.kernel.org, ycheng@google.com, edumazet@google.com,
soheil@google.com
Subject: Re: [PATCH next] tcp: fastopen: fix rcv_wup initialization for TFO server on SYN/data
Date: Thu, 01 Sep 2016 16:40:35 -0700 (PDT) [thread overview]
Message-ID: <20160901.164035.1179448299997912522.davem@davemloft.net> (raw)
In-Reply-To: <1472572523-10449-1-git-send-email-ncardwell@google.com>
From: Neal Cardwell <ncardwell@google.com>
Date: Tue, 30 Aug 2016 11:55:23 -0400
> Yuchung noticed that on the first TFO server data packet sent after
> the (TFO) handshake, the server echoed the TCP timestamp value in the
> SYN/data instead of the timestamp value in the final ACK of the
> handshake. This problem did not happen on regular opens.
>
> The tcp_replace_ts_recent() logic that decides whether to remember an
> incoming TS value needs tp->rcv_wup to hold the latest receive
> sequence number that we have ACKed (latest tp->rcv_nxt we have
> ACKed). This commit fixes this issue by ensuring that a TFO server
> properly updates tp->rcv_wup to match tp->rcv_nxt at the time it sends
> a SYN/ACK for the SYN/data.
>
> Reported-by: Yuchung Cheng <ycheng@google.com>
> Signed-off-by: Neal Cardwell <ncardwell@google.com>
> Signed-off-by: Yuchung Cheng <ycheng@google.com>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Signed-off-by: Soheil Hassas Yeganeh <soheil@google.com>
> Fixes: 168a8f58059a ("tcp: TCP Fast Open Server - main code path")
Applied to 'net', thanks.
prev parent reply other threads:[~2016-09-01 23:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-30 15:55 [PATCH next] tcp: fastopen: fix rcv_wup initialization for TFO server on SYN/data Neal Cardwell
2016-08-30 15:59 ` Neal Cardwell
2016-09-01 23:40 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160901.164035.1179448299997912522.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=soheil@google.com \
--cc=ycheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).