From: Stephen Hemminger <stephen@networkplumber.org>
To: Michal Kubecek <mkubecek@suse.cz>
Cc: "Andrey Jr. Melnikov" <temnota.am@gmail.com>,
Stephen Hemminger <shemminger@osdl.org>,
netdev@vger.kernel.org
Subject: Re: [PATCH] iproute: disallow ip rule del without parameters
Date: Thu, 1 Sep 2016 09:05:40 -0700 [thread overview]
Message-ID: <20160901090540.707a6c87@xeon-e3> (raw)
In-Reply-To: <20160830115156.GB17087@unicorn.suse.cz>
On Tue, 30 Aug 2016 13:51:56 +0200
Michal Kubecek <mkubecek@suse.cz> wrote:
> On Mon, Aug 29, 2016 at 10:53:25AM -0700, Stephen Hemminger wrote:
> > On Wed, 24 Aug 2016 23:43:00 +0300
> > "Andrey Jr. Melnikov" <temnota.am@gmail.com> wrote:
> >
> > > Disallow run `ip rule del` without any parameter to avoid delete any first
> > > rule from table.
> ...
> > Actually ip rule delete without arguments deletes all rules.
> > Which could be a bug or feature depending on the user.
> > I can imagine somebody is doing something like deleting all rules
> > and putting in new ones for PBR.
>
> We have "ip rule flush" for that, don't we?
>
> Michal Kubecek
I went ahead and applied this, seemed better to give error than deleting
all rules.
prev parent reply other threads:[~2016-09-01 16:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-24 20:43 [PATCH] iproute: disallow ip rule del without parameters Andrey Jr. Melnikov
2016-08-29 17:53 ` Stephen Hemminger
2016-08-30 11:51 ` Michal Kubecek
2016-09-01 16:05 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160901090540.707a6c87@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=shemminger@osdl.org \
--cc=temnota.am@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).