From: Stephen Hemminger <stephen@networkplumber.org>
To: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Cc: netdev@vger.kernel.org, sashok@cumulusnetworks.com,
roopa@cumulusnetworks.com
Subject: Re: [PATCH iproute2] ip: route: fix multicast route dumps
Date: Thu, 1 Sep 2016 09:07:19 -0700 [thread overview]
Message-ID: <20160901090719.7c763916@xeon-e3> (raw)
In-Reply-To: <1471697590-24466-1-git-send-email-nikolay@cumulusnetworks.com>
On Sat, 20 Aug 2016 14:53:10 +0200
Nikolay Aleksandrov <nikolay@cumulusnetworks.com> wrote:
> If we have multicast routes and do ip route show table all we'll get the
> following output:
> ...
> multicast ???/32 from ???/32 table default proto static iif eth0
> The "???" are because the rtm_family is set to RTNL_FAMILY_IPMR instead
> (or RTNL_FAMILY_IP6MR for ipv6). Add a simple workaround that returns the
> real family based on the rtm_type (always RTN_MULTICAST for ipmr routes)
> and the rtm_family. Similar workaround is already used in ipmroute, and
> we can use this helper there as well.
>
> After the patch the output is:
> multicast 239.10.10.10/32 from 0.0.0.0/32 table default proto static iif eth0
>
> Also fix a minor whitespace error and switch to tabs.
>
> Reported-by: Satish Ashok <sashok@cumulusnetworks.com>
> Signed-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
This makes sense, applied it.
Hope no one was actually depending on the ??? output.
prev parent reply other threads:[~2016-09-01 16:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-20 12:53 [PATCH iproute2] ip: route: fix multicast route dumps Nikolay Aleksandrov
2016-09-01 16:07 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160901090719.7c763916@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=roopa@cumulusnetworks.com \
--cc=sashok@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).