From: Andrew Lunn <andrew@lunn.ch>
To: Jeremy Linton <jeremy.linton@arm.com>
Cc: netdev@vger.kernel.org, steve.glendinning@shawell.net,
sergei.shtylyov@cogentembedded.com
Subject: Re: [PATCH 1/2] net: smsc911x: Fix register_netdev, phy startup, driver unload ordering
Date: Thu, 1 Sep 2016 21:22:43 +0200 [thread overview]
Message-ID: <20160901192243.GA13292@lunn.ch> (raw)
In-Reply-To: <a33771de-a591-d65e-90e8-33860100e40a@arm.com>
> This patch does add additional code I overlooked to cleanup the phy
> if it fails, I guess in theory that portion could be a prereq patch,
> I will break that portion out. I'm still not sure how to partially
> move the MDIO startup...
Hi Jeremy
You can add a cleanup patch which replaces these hard coded return
values with the value returned by the function calls. Then do the
move.
In general, it is easier to review lots of small obvious patches, than
one big patch with lots of things going on.
Andrew
next prev parent reply other threads:[~2016-09-01 21:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-01 16:25 [PATCH 0/2] net: smsc911x: Move phy and interrupt config Jeremy Linton
2016-09-01 16:25 ` [PATCH 1/2] net: smsc911x: Fix register_netdev, phy startup, driver unload ordering Jeremy Linton
2016-09-01 16:58 ` Andrew Lunn
2016-09-01 18:42 ` Jeremy Linton
2016-09-01 19:22 ` Andrew Lunn [this message]
2016-09-01 16:25 ` [PATCH 2/2] net/smsc911x: Move interrupt allocation to open/stop Jeremy Linton
2016-09-01 17:06 ` Andrew Lunn
2016-09-01 18:47 ` Jeremy Linton
2016-09-01 19:45 ` Andrew Lunn
2016-09-01 20:39 ` Jeremy Linton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160901192243.GA13292@lunn.ch \
--to=andrew@lunn.ch \
--cc=jeremy.linton@arm.com \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=steve.glendinning@shawell.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).