From: Jiri Pirko <jiri@resnulli.us>
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: netdev@vger.kernel.org, jhs@mojatatu.com
Subject: Re: [RFC Patch net-next 0/6] net_sched: really switch to RCU for tc actions
Date: Fri, 2 Sep 2016 09:09:42 +0200 [thread overview]
Message-ID: <20160902070942.GB2150@nanopsycho> (raw)
In-Reply-To: <1472795840-31901-1-git-send-email-xiyou.wangcong@gmail.com>
Fri, Sep 02, 2016 at 07:57:14AM CEST, xiyou.wangcong@gmail.com wrote:
>Currently there are only two tc actions lockless:
>gact and mirred. But they are questionable because
>we don't have anything to prevent a parallel update
>on an existing tc action in hash table while reading
>it on fast path, this could be a problem when a tc
>action becomes complex.
>
>This patchset introduces a few new tc action API's
>based on RCU so that the fast path could now really
>be protected by RCU and we can update existing tc
>actions safely and race-freely.
>
>Obviously this is still _not_ complete yet, I only
>modified mirred action to show the use case of
>the new API's, all the rest actions could switch to
>the new API's too. The new API's are a bit ugly too,
>any suggestion to improve them is welcome.
>
>I tested mirred action with a few test cases, so far
>so good, at least no obvious bugs. ;)
I wonder, do you happen to have a very tiny narrow screen?
next prev parent reply other threads:[~2016-09-02 7:09 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-02 5:57 [RFC Patch net-next 0/6] net_sched: really switch to RCU for tc actions Cong Wang
2016-09-02 5:57 ` [RFC Patch net-next 1/6] net_sched: use RCU for action hash table Cong Wang
2016-09-06 12:47 ` Jamal Hadi Salim
2016-09-06 22:37 ` Cong Wang
2016-09-02 5:57 ` [RFC Patch net-next 2/6] net_sched: introduce tcf_hash_replace() Cong Wang
2016-09-06 12:52 ` Jamal Hadi Salim
2016-09-06 22:34 ` Cong Wang
2016-09-02 5:57 ` [RFC Patch net-next 3/6] net_sched: return NULL in tcf_hash_check() Cong Wang
2016-09-02 5:57 ` [RFC Patch net-next 4/6] net_sched: introduce tcf_hash_copy() Cong Wang
2016-09-02 5:57 ` [RFC Patch net-next 5/6] net_sched: use rcu in fast path Cong Wang
2016-09-06 14:52 ` Eric Dumazet
2016-09-08 6:04 ` John Fastabend
2016-09-08 13:28 ` Eric Dumazet
2016-09-08 15:35 ` [PATCH net] net_sched: act_mirred: full rcu conversion Eric Dumazet
2016-09-08 15:47 ` John Fastabend
2016-09-08 15:51 ` Eric Dumazet
2016-09-09 5:26 ` Cong Wang
2016-09-09 12:23 ` Eric Dumazet
2016-09-09 15:52 ` John Fastabend
2016-09-12 6:12 ` Cong Wang
2016-09-12 15:34 ` John Fastabend
2016-09-09 5:24 ` Cong Wang
2016-09-09 5:48 ` Alexei Starovoitov
2016-09-09 5:59 ` Cong Wang
2016-09-09 12:25 ` Eric Dumazet
2016-09-09 12:23 ` Eric Dumazet
2016-09-12 5:46 ` Cong Wang
2016-09-08 15:49 ` [RFC Patch net-next 5/6] net_sched: use rcu in fast path John Fastabend
2016-09-09 5:54 ` Cong Wang
2016-09-09 15:25 ` John Fastabend
2016-09-09 5:49 ` Cong Wang
2016-09-02 5:57 ` [RFC Patch net-next 6/6] net_sched: switch to RCU API for act_mirred Cong Wang
2016-09-02 7:09 ` Jiri Pirko [this message]
2016-09-02 19:44 ` [RFC Patch net-next 0/6] net_sched: really switch to RCU for tc actions Cong Wang
2016-09-07 16:23 ` John Fastabend
2016-09-08 6:05 ` John Fastabend
2016-09-09 5:22 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160902070942.GB2150@nanopsycho \
--to=jiri@resnulli.us \
--cc=jhs@mojatatu.com \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox