From: Stephen Hemminger <stephen@networkplumber.org>
To: Hangbin Liu <liuhangbin@gmail.com>
Cc: netdev@vger.kernel.org, Phil Sutter <phil@nwl.cc>
Subject: Re: [PATCH iproute2 net-next] nstat: add sctp snmp support
Date: Fri, 2 Sep 2016 12:46:49 -0700 [thread overview]
Message-ID: <20160902124649.1ead9f4a@xeon-e3> (raw)
In-Reply-To: <1472800358-31881-1-git-send-email-liuhangbin@gmail.com>
On Fri, 2 Sep 2016 15:12:38 +0800
Hangbin Liu <liuhangbin@gmail.com> wrote:
> SCTP module was not load by default. But this should be OK since we will not
> load table if fdopen() failed.
>
> Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
This seems like a bad idea for the normal distro user.
If they run nstat command the SCTP kernel module would get loaded even
if never used.
Makes more sense not to display SCTP statistics if it isn't loaded.
next prev parent reply other threads:[~2016-09-02 19:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-02 7:12 [PATCH iproute2 net-next] nstat: add sctp snmp support Hangbin Liu
2016-09-02 10:09 ` Phil Sutter
2016-09-05 3:31 ` Hangbin Liu
2016-09-02 19:46 ` Stephen Hemminger [this message]
2016-09-02 19:48 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160902124649.1ead9f4a@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).