From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: Eugene Krasnikov <k.eugene.e@gmail.com>,
wcn36xx@lists.infradead.org, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v3 1/2] wcn36xx: Transition driver to SMD client
Date: Fri, 2 Sep 2016 09:46:23 -0700 [thread overview]
Message-ID: <20160902164623.GY15161@tuxbot> (raw)
In-Reply-To: <87mvjqz2ul.fsf@kamboji.qca.qualcomm.com>
On Fri 02 Sep 09:24 PDT 2016, Kalle Valo wrote:
> Bjorn Andersson <bjorn.andersson@linaro.org> writes:
>
> > The wcn36xx wifi driver follows the life cycle of the WLAN_CTRL SMD
> > channel, as such it should be a SMD client. This patch makes this
> > transition, now that we have the necessary frameworks available.
> >
> > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
>
> [...]
>
> > --- a/drivers/net/wireless/ath/wcn36xx/Kconfig
> > +++ b/drivers/net/wireless/ath/wcn36xx/Kconfig
> > @@ -1,6 +1,6 @@
> > config WCN36XX
> > tristate "Qualcomm Atheros WCN3660/3680 support"
> > - depends on MAC80211 && HAS_DMA
> > + depends on MAC80211 && HAS_DMA && QCOM_SMD
>
> While I had this patch on my pending branch I noticed that I can't
> compile wcn36xx on x86 anymore. This is actually quite inconvenient, for
> example then it's easy to miss mac80211 API changes etc. Is there any
> way we could continue build testing wcn36xx on x86 (or all) platforms?
>
Sorry about that, we should at least be able to COMPILE_TEST it in
non-qcom builds. Thanks for letting me know.
And the driver should also depend on QCOM_WCNSS_CTRL, in the normal
case.
I'll respin this, unless you prefer an incremental patch for those
changes(?)
> Also what about older platforms? Earlier I used wcn36xx on my Nexus 4
> with help of backports project. I can't do that anymore, right?
>
This has been tested on 8064, 8974 and 8916. So your Nexus 4 is covered.
Unfortunately I don't have a Nexus 4, but we currently have Nexus 7
(the 8064 version), Xperia Z, Xperia Z1 and DB410c using this chip and
all four has been tested with this code.
I've staged the PIL/remoteproc (firmware "loader") driver for v4.9, so
with this patch the only thing missing to fill in the dts files is one
clock from the RPM.
JFYI, There seems to be some race in the removal path, which I will look
into. But I would prefer if we could merge this to make the driver
usable, and more accessible to work on.
Regards,
Bjorn
next prev parent reply other threads:[~2016-09-02 16:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-01 14:51 [PATCH v3 1/2] wcn36xx: Transition driver to SMD client Bjorn Andersson
2016-09-01 14:51 ` [PATCH v3 2/2] wcn36xx: Implement firmware assisted scan Bjorn Andersson
2016-09-02 16:24 ` [PATCH v3 1/2] wcn36xx: Transition driver to SMD client Kalle Valo
2016-09-02 16:38 ` Marcel Holtmann
2016-09-02 16:46 ` Bjorn Andersson [this message]
2016-09-02 18:23 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160902164623.GY15161@tuxbot \
--to=bjorn.andersson@linaro.org \
--cc=k.eugene.e@gmail.com \
--cc=kvalo@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=wcn36xx@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).