From: Shmulik Ladkani <shmulik.ladkani@gmail.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: "David S. Miller" <davem@davemloft.net>,
Hannes Frederic Sowa <hannes@stressinduktion.org>,
Rainer Weikusat <rweikusat@mobileactivedefense.com>,
Eric Dumazet <edumazet@google.com>, willy tarreau <w@1wt.eu>,
netdev@vger.kernel.org
Subject: Re: [PATCH 1/2] Revert "af_unix: Fix splice-bind deadlock"
Date: Sat, 3 Sep 2016 20:00:13 +0300 [thread overview]
Message-ID: <20160903200013.14111d91@halley> (raw)
In-Reply-To: <alpine.LFD.2.20.1609021106060.4039@i7>
On Fri, 2 Sep 2016 11:09:23 -0700 (PDT) Linus Torvalds <torvalds@linux-foundation.org> wrote:
> From: Linus Torvalds <torvalds@linux-foundation.org>
> Date: Thu, 1 Sep 2016 14:56:49 -0700
> Subject: [PATCH 1/2] Revert "af_unix: Fix splice-bind deadlock"
>
> This reverts commit c845acb324aa85a39650a14e7696982ceea75dc1.
>
> It turns out that it just replaces one deadlock with another one: we can
> still get the wrong lock ordering with the readlock due to overlayfs
> calling back into the filesystem layer and still taking the vfs locks
> after the readlock.
>
> The proper solution ends up being to just split the readlock into two
> pieces: the bind lock (taken *outside* the vfs locks) and the IO lock
> (taken *inside* the filesystem locks). The two locks are independent
> anyway.
>
> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
> ---
>
> This is not a completely clean revert, because other changes had happened
> in this area since that commit, but the conflicts were pretty trivial.
Reviewed-by: Shmulik Ladkani <shmulik.ladkani@gmail.com>
next prev parent reply other threads:[~2016-09-03 17:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-02 18:09 [PATCH 1/2] Revert "af_unix: Fix splice-bind deadlock" Linus Torvalds
2016-09-03 17:00 ` Shmulik Ladkani [this message]
2016-09-04 20:29 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160903200013.14111d91@halley \
--to=shmulik.ladkani@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hannes@stressinduktion.org \
--cc=netdev@vger.kernel.org \
--cc=rweikusat@mobileactivedefense.com \
--cc=torvalds@linux-foundation.org \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).