From: David Miller <davem@davemloft.net>
To: joe@perches.com
Cc: Yuval.Mintz@qlogic.com, Ariel.Elior@qlogic.com,
everest-linux-l2@qlogic.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] qed: Remove OOM messages
Date: Sun, 04 Sep 2016 13:28:54 -0700 (PDT) [thread overview]
Message-ID: <20160904.132854.1438256363591084718.davem@davemloft.net> (raw)
In-Reply-To: <6d6f56d8324237957b19f069357e2aa9e4bcd959.1472836194.git.joe@perches.com>
From: Joe Perches <joe@perches.com>
Date: Fri, 2 Sep 2016 10:48:47 -0700
> These messages are unnecessary as OOM allocation failures already do
> a dump_stack() giving more or less the same information.
>
> $ size drivers/net/ethernet/qlogic/qed/built-in.o* (defconfig x86-64)
> text data bss dec hex filename
> 126849 27968 32800 187617 2dce1 drivers/net/ethernet/qlogic/qed/built-in.o.new
> 131506 27968 32800 192274 2ef12 drivers/net/ethernet/qlogic/qed/built-in.o.old
>
> Miscellanea:
>
> o Change allocs to the generally preferred forms where possible.
>
> Signed-off-by: Joe Perches <joe@perches.com>
Joe can you respin this against net-next?
It applies against 'net' but this isn't really a critical bug fix and
it'll also create conflicts against net-next.
Thanks.
next prev parent reply other threads:[~2016-09-04 20:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-01 6:45 [net:master 27/28] drivers/net/ethernet/qlogic/qed/qed_dcbx.c:1230:13-20: WARNING: kzalloc should be used for dcbx_info, instead of kmalloc/memset kbuild test robot
2016-09-01 6:45 ` [PATCH] qed: fix kzalloc-simple.cocci warnings kbuild test robot
2016-09-01 7:37 ` Yuval Mintz
2016-09-01 16:48 ` David Miller
2016-09-02 17:44 ` Joe Perches
2016-09-02 17:48 ` [PATCH] qed: Remove OOM messages Joe Perches
2016-09-04 8:18 ` Yuval Mintz
2016-09-04 20:28 ` David Miller [this message]
2016-09-04 21:22 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160904.132854.1438256363591084718.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Ariel.Elior@qlogic.com \
--cc=Yuval.Mintz@qlogic.com \
--cc=everest-linux-l2@qlogic.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).