From: Jiri Benc <jbenc@redhat.com>
To: zyjzyj2000@gmail.com
Cc: netdev@vger.kernel.org, pabeni@redhat.com, daniel@iogearbox.net,
pshelar@nicira.com, aduyck@mirantis.com,
hannes@stressinduktion.org, davem@davemloft.net
Subject: Re: [PATCH 1/1] vxlan: make the struct nlattr variable const
Date: Sun, 4 Sep 2016 14:27:53 +0200 [thread overview]
Message-ID: <20160904142753.3b5bc6a1@griffin> (raw)
In-Reply-To: <1472911630-22285-1-git-send-email-zyjzyj2000@gmail.com>
On Sat, 3 Sep 2016 22:07:10 +0800, zyjzyj2000@gmail.com wrote:
> From: Zhu Yanjun <zyjzyj2000@gmail.com>
>
> The struct nlattr variable should not be changed.
True. But the only caller is vxlan_fdb_parse which doesn't have its tb
parameter const, so what's the point?
Now, the tb parameter of vxlan_fdb_parse could be changed to const.
This again doesn't make much sense without modifying its callers, which
are vxlan_fdb_add and vxlan_fdb_delete. And those are net_device_ops
hooks. Have you considered looking into those (ndo_fdb_*) and turning
the struct nlattr ** to const (that is, if it's possible)?
Jiri
prev parent reply other threads:[~2016-09-04 12:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-03 14:07 [PATCH 1/1] vxlan: make the struct nlattr variable const zyjzyj2000
2016-09-04 12:27 ` Jiri Benc [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160904142753.3b5bc6a1@griffin \
--to=jbenc@redhat.com \
--cc=aduyck@mirantis.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=hannes@stressinduktion.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pshelar@nicira.com \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).