From: Jiri Benc <jbenc@redhat.com>
To: Haishuang Yan <yanhaishuang@cmss.chinamobile.com>
Cc: "David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] vxlan: Update tx_errors statistics if vxlan_build_skb return err.
Date: Sun, 4 Sep 2016 16:12:33 +0200 [thread overview]
Message-ID: <20160904161233.063d0009@griffin> (raw)
In-Reply-To: <1472986371-75583-1-git-send-email-yanhaishuang@cmss.chinamobile.com>
On Sun, 4 Sep 2016 18:52:51 +0800, Haishuang Yan wrote:
> If vxlan_build_skb return err < 0, tx_errors should be also increased.
>
> Signed-off-by: Haishuang Yan <yanhaishuang@cmss.chinamobile.com>
> ---
> drivers/net/vxlan.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
> index f605a36..2c72dcd 100644
> --- a/drivers/net/vxlan.c
> +++ b/drivers/net/vxlan.c
> @@ -2103,6 +2103,7 @@ static void vxlan_xmit_one(struct sk_buff *skb, struct net_device *dev,
> vni, md, flags, udp_sum);
> if (err < 0) {
> dst_release(ndst);
> + dev->stats.tx_errors++;
> return;
> }
> udp_tunnel6_xmit_skb(ndst, sk, skb, dev,
Acked-by: Jiri Benc <jbenc@redhat.com>
The error path in vxlan_xmit_one deserves complete rework, though.
Jiri
next prev parent reply other threads:[~2016-09-04 14:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-04 10:52 [PATCH] vxlan: Update tx_errors statistics if vxlan_build_skb return err Haishuang Yan
2016-09-04 14:12 ` Jiri Benc [this message]
2016-09-06 20:42 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160904161233.063d0009@griffin \
--to=jbenc@redhat.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yanhaishuang@cmss.chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).