From: David Miller <davem@davemloft.net>
To: davej@codemonkey.org.uk
Cc: netdev@vger.kernel.org, kafai@fb.com
Subject: Re: ipv6: release dst in ping_v6_sendmsg
Date: Tue, 06 Sep 2016 12:56:05 -0700 (PDT) [thread overview]
Message-ID: <20160906.125605.2276804616901457581.davem@davemloft.net> (raw)
In-Reply-To: <20160902183950.p3iv25jnuwmq74sg@codemonkey.org.uk>
From: Dave Jones <davej@codemonkey.org.uk>
Date: Fri, 2 Sep 2016 14:39:50 -0400
> Neither the failure or success paths of ping_v6_sendmsg release
> the dst it acquires. This leads to a flood of warnings from
> "net/core/dst.c:288 dst_release" on older kernels that
> don't have 8bf4ada2e21378816b28205427ee6b0e1ca4c5f1 backported.
>
> That patch optimistically hoped this had been fixed post 3.10, but
> it seems at least one case wasn't, where I've seen this triggered
> a lot from machines doing unprivileged icmp sockets.
>
> Cc: Martin Lau <kafai@fb.com>
> Signed-off-by: Dave Jones <davej@codemonkey.org.uk>
Applied and queued up for -stable, thanks Dave.
prev parent reply other threads:[~2016-09-06 19:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-02 18:39 ipv6: release dst in ping_v6_sendmsg Dave Jones
2016-09-06 17:36 ` Martin KaFai Lau
2016-09-06 17:52 ` Eric Dumazet
2016-09-06 18:50 ` Dave Jones
2016-09-06 19:56 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160906.125605.2276804616901457581.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=davej@codemonkey.org.uk \
--cc=kafai@fb.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).