From: David Miller <davem@davemloft.net>
To: joe@perches.com
Cc: Yuval.Mintz@qlogic.com, Ariel.Elior@qlogic.com,
everest-linux-l2@qlogic.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [net-next PATCH V2] qed: Remove OOM messages
Date: Tue, 06 Sep 2016 13:54:42 -0700 (PDT) [thread overview]
Message-ID: <20160906.135442.1020937848957246873.davem@davemloft.net> (raw)
In-Reply-To: <c79eb789a95464ba5dc06229d905ca1ae00a66c8.1473024037.git.joe@perches.com>
From: Joe Perches <joe@perches.com>
Date: Sun, 4 Sep 2016 14:24:03 -0700
> These messages are unnecessary as OOM allocation failures already do
> a dump_stack() giving more or less the same information.
>
> $ size drivers/net/ethernet/qlogic/qed/built-in.o* (defconfig x86-64)
> text data bss dec hex filename
> 127817 27969 32800 188586 2e0aa drivers/net/ethernet/qlogic/qed/built-in.o.new
> 132474 27969 32800 193243 2f2db drivers/net/ethernet/qlogic/qed/built-in.o.old
>
> Miscellanea:
>
> o Change allocs to the generally preferred forms where possible.
>
> Signed-off-by: Joe Perches <joe@perches.com>
Applied.
prev parent reply other threads:[~2016-09-06 20:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-04 21:24 [net-next PATCH V2] qed: Remove OOM messages Joe Perches
2016-09-06 20:54 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160906.135442.1020937848957246873.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Ariel.Elior@qlogic.com \
--cc=Yuval.Mintz@qlogic.com \
--cc=everest-linux-l2@qlogic.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).