* [PATCH] tcp: cwnd does not increase in TCP YeAH
@ 2016-09-05 4:03 Artem Germanov
2016-09-05 12:52 ` Neal Cardwell
2016-09-06 20:58 ` David Miller
0 siblings, 2 replies; 5+ messages in thread
From: Artem Germanov @ 2016-09-05 4:03 UTC (permalink / raw)
To: netdev, davem, nanditad, edumazet, ncardwell, ycheng
Commit 76174004a0f19785a328f40388e87e982bbf69b9
(tcp: do not slow start when cwnd equals ssthresh )
introduced regression in TCP YeAH. Using 100ms delay 1% loss virtual
ethernet link kernel 4.2 shows bandwidth ~500KB/s for single TCP
connection and kernel 4.3 and above (including 4.8-rc4) shows bandwidth
~100KB/s.
That is caused by stalled cwnd when cwnd equals ssthresh. This patch
fixes it by proper increasing cwnd in this case.
Signed-off-by: Artem Germanov <agermanov@anchorfree.com>
---
--- net/ipv4/tcp_yeah.c.orig 2016-09-04 09:53:01.000000000 -0700
+++ net/ipv4/tcp_yeah.c 2016-09-04 09:53:40.000000000 -0700
@@ -76,7 +76,7 @@ static void tcp_yeah_cong_avoid(struct s
if (!tcp_is_cwnd_limited(sk))
return;
- if (tp->snd_cwnd <= tp->snd_ssthresh)
+ if (tcp_in_slow_start(tp))
tcp_slow_start(tp, acked);
else if (!yeah->doing_reno_now) {
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] tcp: cwnd does not increase in TCP YeAH
2016-09-05 4:03 [PATCH] tcp: cwnd does not increase in TCP YeAH Artem Germanov
@ 2016-09-05 12:52 ` Neal Cardwell
2016-09-06 20:58 ` David Miller
1 sibling, 0 replies; 5+ messages in thread
From: Neal Cardwell @ 2016-09-05 12:52 UTC (permalink / raw)
To: Artem Germanov
Cc: Netdev, David Miller, Nandita Dukkipati, Eric Dumazet,
Yuchung Cheng
On Mon, Sep 5, 2016 at 12:03 AM, Artem Germanov
<agermanov@anchorfree.com> wrote:
>
> Commit 76174004a0f19785a328f40388e87e982bbf69b9
> (tcp: do not slow start when cwnd equals ssthresh )
> introduced regression in TCP YeAH. Using 100ms delay 1% loss virtual
> ethernet link kernel 4.2 shows bandwidth ~500KB/s for single TCP
> connection and kernel 4.3 and above (including 4.8-rc4) shows bandwidth
> ~100KB/s.
> That is caused by stalled cwnd when cwnd equals ssthresh. This patch
> fixes it by proper increasing cwnd in this case.
>
> Signed-off-by: Artem Germanov <agermanov@anchorfree.com>
Acked-by: Neal Cardwell <ncardwell@google.com>
neal
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] tcp: cwnd does not increase in TCP YeAH
2016-09-05 4:03 [PATCH] tcp: cwnd does not increase in TCP YeAH Artem Germanov
2016-09-05 12:52 ` Neal Cardwell
@ 2016-09-06 20:58 ` David Miller
2016-09-07 17:49 ` [PATCH v2] " Artem Germanov
1 sibling, 1 reply; 5+ messages in thread
From: David Miller @ 2016-09-06 20:58 UTC (permalink / raw)
To: agermanov; +Cc: netdev, nanditad, edumazet, ncardwell, ycheng
From: Artem Germanov <agermanov@anchorfree.com>
Date: Sun, 4 Sep 2016 21:03:27 -0700
> Commit 76174004a0f19785a328f40388e87e982bbf69b9
> (tcp: do not slow start when cwnd equals ssthresh )
> introduced regression in TCP YeAH. Using 100ms delay 1% loss virtual
> ethernet link kernel 4.2 shows bandwidth ~500KB/s for single TCP
> connection and kernel 4.3 and above (including 4.8-rc4) shows
> bandwidth ~100KB/s.
> That is caused by stalled cwnd when cwnd equals ssthresh. This patch
> fixes it by proper increasing cwnd in this case.
>
> Signed-off-by: Artem Germanov <agermanov@anchorfree.com>
This patch won't apply properly.
First, it isn't rooted properly.
Second, all the TAB characters have been mangled into spaces.
Please fix these problems, send a test patch to yourself, and only
resubmit this patch when you can successfully apply that test patch.
Thank you.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] tcp: cwnd does not increase in TCP YeAH
2016-09-06 20:58 ` David Miller
@ 2016-09-07 17:49 ` Artem Germanov
2016-09-09 0:16 ` David Miller
0 siblings, 1 reply; 5+ messages in thread
From: Artem Germanov @ 2016-09-07 17:49 UTC (permalink / raw)
To: netdev, davem, nanditad, edumazet, ncardwell, ycheng,
Dmitry Adamushko
Commit 76174004a0f19785a328f40388e87e982bbf69b9
(tcp: do not slow start when cwnd equals ssthresh )
introduced regression in TCP YeAH. Using 100ms delay 1% loss virtual
ethernet link kernel 4.2 shows bandwidth ~500KB/s for single TCP
connection and kernel 4.3 and above (including 4.8-rc4) shows bandwidth
~100KB/s.
That is caused by stalled cwnd when cwnd equals ssthresh. This patch
fixes it by proper increasing cwnd in this case.
Signed-off-by: Artem Germanov <agermanov@anchorfree.com>
Acked-by: Dmitry Adamushko <d.adamushko@anchorfree.com>
---
diff --git a/net/ipv4/tcp_yeah.c b/net/ipv4/tcp_yeah.c
index 028eb04..9c5fc97 100644
--- a/net/ipv4/tcp_yeah.c
+++ b/net/ipv4/tcp_yeah.c
@@ -76,7 +76,7 @@ static void tcp_yeah_cong_avoid(struct sock *sk, u32 ack, u32 acked)
if (!tcp_is_cwnd_limited(sk))
return;
- if (tp->snd_cwnd <= tp->snd_ssthresh)
+ if (tcp_in_slow_start(tp))
tcp_slow_start(tp, acked);
else if (!yeah->doing_reno_now) {
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH v2] tcp: cwnd does not increase in TCP YeAH
2016-09-07 17:49 ` [PATCH v2] " Artem Germanov
@ 2016-09-09 0:16 ` David Miller
0 siblings, 0 replies; 5+ messages in thread
From: David Miller @ 2016-09-09 0:16 UTC (permalink / raw)
To: agermanov; +Cc: netdev, nanditad, edumazet, ncardwell, ycheng, d.adamushko
From: Artem Germanov <agermanov@anchorfree.com>
Date: Wed, 7 Sep 2016 10:49:36 -0700
> Commit 76174004a0f19785a328f40388e87e982bbf69b9
> (tcp: do not slow start when cwnd equals ssthresh )
> introduced regression in TCP YeAH. Using 100ms delay 1% loss virtual
> ethernet link kernel 4.2 shows bandwidth ~500KB/s for single TCP
> connection and kernel 4.3 and above (including 4.8-rc4) shows bandwidth
> ~100KB/s.
> That is caused by stalled cwnd when cwnd equals ssthresh. This patch
> fixes it by proper increasing cwnd in this case.
>
> Signed-off-by: Artem Germanov <agermanov@anchorfree.com>
> Acked-by: Dmitry Adamushko <d.adamushko@anchorfree.com>
Applied and queued up for -stable, thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-09-09 0:16 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-05 4:03 [PATCH] tcp: cwnd does not increase in TCP YeAH Artem Germanov
2016-09-05 12:52 ` Neal Cardwell
2016-09-06 20:58 ` David Miller
2016-09-07 17:49 ` [PATCH v2] " Artem Germanov
2016-09-09 0:16 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).