From: David Miller <davem@davemloft.net>
To: avagin@openvz.org
Cc: netdev@vger.kernel.org, herbert@gondor.apana.org.au
Subject: Re: [PATCH net-next] netlink: don't forget to release a rhashtable_iter structure
Date: Tue, 06 Sep 2016 17:41:37 -0700 (PDT) [thread overview]
Message-ID: <20160906.174137.1869816645707925029.davem@davemloft.net> (raw)
In-Reply-To: <1473186219-13061-1-git-send-email-avagin@openvz.org>
From: Andrei Vagin <avagin@openvz.org>
Date: Tue, 6 Sep 2016 11:23:39 -0700
> This bug was detected by kmemleak:
> unreferenced object 0xffff8804269cc3c0 (size 64):
> comm "criu", pid 1042, jiffies 4294907360 (age 13.713s)
> hex dump (first 32 bytes):
> a0 32 cc 2c 04 88 ff ff 00 00 00 00 00 00 00 00 .2.,............
> 00 01 00 00 00 00 ad de 00 02 00 00 00 00 ad de ................
> backtrace:
> [<ffffffff8184dffa>] kmemleak_alloc+0x4a/0xa0
> [<ffffffff8124720f>] kmem_cache_alloc_trace+0x10f/0x280
> [<ffffffffa02864cc>] __netlink_diag_dump+0x26c/0x290 [netlink_diag]
>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
> Fixes: ad202074320c ("netlink: Use rhashtable walk interface in diag dump")
> Signed-off-by: Andrei Vagin <avagin@openvz.org>
Hmmm, why isn't this handled by netlink_diag_dump_done()?
It seems like the intent is to have the hashtable iter be cached
across multiple __netlink_diag_dump() calls within a single
netlink_diag_dump invocation.
next prev parent reply other threads:[~2016-09-07 0:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-06 18:23 [PATCH net-next] netlink: don't forget to release a rhashtable_iter structure Andrei Vagin
2016-09-07 0:41 ` David Miller [this message]
2016-09-07 4:28 ` Andrei Vagin
2016-09-07 4:31 ` [PATCH net-next v2] " Andrei Vagin
2016-09-07 4:55 ` Herbert Xu
2016-09-08 0:29 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160906.174137.1869816645707925029.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=avagin@openvz.org \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).