From: David Miller <davem@davemloft.net>
To: linus.walleij@linaro.org
Cc: netdev@vger.kernel.org, steve.glendinning@shawell.net,
linux@roeck-us.net, jeremy.linton@arm.com,
kamlakant.patel@broadcom.com, p.fedin@samsung.com
Subject: Re: [PATCH 2/2 v3] net: smsc911x: request and deassert optional RESET GPIO
Date: Wed, 07 Sep 2016 21:06:17 -0700 (PDT) [thread overview]
Message-ID: <20160907.210617.685340162025675932.davem@davemloft.net> (raw)
In-Reply-To: <1473256422-14012-1-git-send-email-linus.walleij@linaro.org>
From: Linus Walleij <linus.walleij@linaro.org>
Date: Wed, 7 Sep 2016 15:53:42 +0200
> On some systems (such as the Qualcomm APQ8060 Dragonboard) the
> RESET signal of the SMSC911x is not pulled up by a resistor (or
> the internal pull-up that will pull it up if the pin is not
> even connected) but instead connected to a GPIO line, so that
> the operating system must explicitly deassert RESET before use.
>
> Support this in the SMSC911x driver so this ethernet connector
> can be used on such targets.
>
> Notice that we request the line to go logical low (deassert)
> whilst the line on the actual component is active low. This
> is managed in the respective hardware description when
> specifying the GPIO line with e.g. device tree or ACPI. With
> device tree it looks like this in one case:
>
> reset-gpios = <&tlmm 30 GPIO_ACTIVE_LOW>;
>
> Which means that logically requesting the RESET line to be
> deasserted will result in the line being driven high, taking
> the device out of reset.
>
> Cc: Jeremy Linton <jeremy.linton@arm.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Applied.
prev parent reply other threads:[~2016-09-08 4:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-07 13:53 [PATCH 2/2 v3] net: smsc911x: request and deassert optional RESET GPIO Linus Walleij
2016-09-07 23:11 ` Jeremy Linton
2016-09-08 4:06 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160907.210617.685340162025675932.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jeremy.linton@arm.com \
--cc=kamlakant.patel@broadcom.com \
--cc=linus.walleij@linaro.org \
--cc=linux@roeck-us.net \
--cc=netdev@vger.kernel.org \
--cc=p.fedin@samsung.com \
--cc=steve.glendinning@shawell.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).