From: David Miller <davem@davemloft.net>
To: lorenzo@google.com
Cc: netdev@vger.kernel.org, eric.dumazet@gmail.com,
dsa@cumulusnetworks.com, ek@google.com
Subject: Re: [PATCH net-next v3] net: inet: diag: expose the socket mark to privileged processes.
Date: Thu, 08 Sep 2016 16:13:48 -0700 (PDT) [thread overview]
Message-ID: <20160908.161348.297729487225819070.davem@davemloft.net> (raw)
In-Reply-To: <1473262945-144932-1-git-send-email-lorenzo@google.com>
From: Lorenzo Colitti <lorenzo@google.com>
Date: Thu, 8 Sep 2016 00:42:25 +0900
> This adds the capability for a process that has CAP_NET_ADMIN on
> a socket to see the socket mark in socket dumps.
>
> Commit a52e95abf772 ("net: diag: allow socket bytecode filters to
> match socket marks") recently gave privileged processes the
> ability to filter socket dumps based on mark. This patch is
> complementary: it ensures that the mark is also passed to
> userspace in the socket's netlink attributes. It is useful for
> tools like ss which display information about sockets.
>
> Tested: https://android-review.googlesource.com/270210
> Signed-off-by: Lorenzo Colitti <lorenzo@google.com>
Applied, but the argument list of inet_sk_diag_fill is starting to get out
of control.
next prev parent reply other threads:[~2016-09-08 23:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-07 15:42 [PATCH net-next v3] net: inet: diag: expose the socket mark to privileged processes Lorenzo Colitti
2016-09-08 23:13 ` David Miller [this message]
2016-09-09 0:48 ` Lorenzo Colitti
2016-09-09 0:57 ` David Miller
2016-09-09 5:23 ` Lorenzo Colitti
2016-09-14 4:00 ` Lorenzo Colitti
2016-09-14 4:19 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160908.161348.297729487225819070.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dsa@cumulusnetworks.com \
--cc=ek@google.com \
--cc=eric.dumazet@gmail.com \
--cc=lorenzo@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).