From: David Miller <davem@davemloft.net>
To: thomas.zeitlhofer+lkml@ze-it.at
Cc: steffen.klassert@secunet.com, herbert@gondor.apana.org.au,
netdev@vger.kernel.org
Subject: Re: [PATCH v2] vti: use right inner_mode for inbound inter address family policy checks
Date: Thu, 08 Sep 2016 17:17:57 -0700 (PDT) [thread overview]
Message-ID: <20160908.171757.1653874905057849577.davem@davemloft.net> (raw)
In-Reply-To: <20160907184038.2neg44xtvlunlrmu@toau>
From: thomas.zeitlhofer+lkml@ze-it.at
Date: Wed, 7 Sep 2016 20:40:38 +0200
> In case of inter address family tunneling (IPv6 over vti4 or IPv4 over
> vti6), the inbound policy checks in vti_rcv_cb() and vti6_rcv_cb() are
> using the wrong address family. As a result, all inbound inter address
> family traffic is dropped.
>
> Use the xfrm_ip2inner_mode() helper, as done in xfrm_input() (i.e., also
> increment LINUX_MIB_XFRMINSTATEMODEERROR in case of error), to select the
> inner_mode that contains the right address family for the inbound policy
> checks.
>
> Signed-off-by: Thomas Zeitlhofer <thomas.zeitlhofer+lkml@ze-it.at>
Steffen please review this new version of the patch.
Thanks.
next prev parent reply other threads:[~2016-09-09 0:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-04 10:57 [PATCH] vti: use right inner_mode for inbound inter address family policy checks Thomas Zeitlhofer
2016-09-06 11:15 ` Steffen Klassert
2016-09-07 18:40 ` [PATCH v2] " thomas.zeitlhofer+lkml
2016-09-09 0:17 ` David Miller [this message]
2016-09-09 8:36 ` Steffen Klassert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160908.171757.1653874905057849577.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
--cc=thomas.zeitlhofer+lkml@ze-it.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).