* [PATCH net-next] rtnetlink: remove unused ifla_stats_policy
@ 2016-09-07 20:57 Stephen Hemminger
2016-09-09 0:23 ` David Miller
2016-09-09 23:53 ` David Miller
0 siblings, 2 replies; 4+ messages in thread
From: Stephen Hemminger @ 2016-09-07 20:57 UTC (permalink / raw)
To: David Miller; +Cc: netdev
This structure is defined but never used. Flagged with W=1
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
--- a/net/core/rtnetlink.c 2016-09-07 13:55:17.030107744 -0700
+++ b/net/core/rtnetlink.c 2016-09-07 13:55:45.190236855 -0700
@@ -3669,10 +3669,6 @@ nla_put_failure:
return -EMSGSIZE;
}
-static const struct nla_policy ifla_stats_policy[IFLA_STATS_MAX + 1] = {
- [IFLA_STATS_LINK_64] = { .len = sizeof(struct rtnl_link_stats64) },
-};
-
static size_t if_nlmsg_stats_size(const struct net_device *dev,
u32 filter_mask)
{
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net-next] rtnetlink: remove unused ifla_stats_policy
2016-09-07 20:57 [PATCH net-next] rtnetlink: remove unused ifla_stats_policy Stephen Hemminger
@ 2016-09-09 0:23 ` David Miller
2016-09-09 2:56 ` Roopa Prabhu
2016-09-09 23:53 ` David Miller
1 sibling, 1 reply; 4+ messages in thread
From: David Miller @ 2016-09-09 0:23 UTC (permalink / raw)
To: stephen; +Cc: netdev, roopa
From: Stephen Hemminger <stephen@networkplumber.org>
Date: Wed, 7 Sep 2016 13:57:36 -0700
> This structure is defined but never used. Flagged with W=1
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
This comes from commit 10c9ead9f3c6bb24bddc9a96681f7d58e6623966
("rtnetlink: add new RTM_GETSTATS message to dump link stats")
Roopa, did you intentionally put this here unreferenced for the
purposes or documentation or something like that?
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net-next] rtnetlink: remove unused ifla_stats_policy
2016-09-09 0:23 ` David Miller
@ 2016-09-09 2:56 ` Roopa Prabhu
0 siblings, 0 replies; 4+ messages in thread
From: Roopa Prabhu @ 2016-09-09 2:56 UTC (permalink / raw)
To: David Miller; +Cc: stephen, netdev
On 9/8/16, 5:23 PM, David Miller wrote:
> From: Stephen Hemminger <stephen@networkplumber.org>
> Date: Wed, 7 Sep 2016 13:57:36 -0700
>
>> This structure is defined but never used. Flagged with W=1
>>
>> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> This comes from commit 10c9ead9f3c6bb24bddc9a96681f7d58e6623966
> ("rtnetlink: add new RTM_GETSTATS message to dump link stats")
>
> Roopa, did you intentionally put this here unreferenced for the
> purposes or documentation or something like that?
I went back and looked at all my submissions to remember why i had it.
I don't seem to have used it anywhere...but i had expressed an intent to use
it to parse filter attributes in incoming stats requests in my first few versions.
I possibly just forgot to drop it after i moved to a mask to filter incoming stats requests.
thanks for checking...
Acked-by: Roopa Prabhu <roopa@cumulusnetworks.com>
and thanks stephen for cleaning this up.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] rtnetlink: remove unused ifla_stats_policy
2016-09-07 20:57 [PATCH net-next] rtnetlink: remove unused ifla_stats_policy Stephen Hemminger
2016-09-09 0:23 ` David Miller
@ 2016-09-09 23:53 ` David Miller
1 sibling, 0 replies; 4+ messages in thread
From: David Miller @ 2016-09-09 23:53 UTC (permalink / raw)
To: stephen; +Cc: netdev
From: Stephen Hemminger <stephen@networkplumber.org>
Date: Wed, 7 Sep 2016 13:57:36 -0700
> This structure is defined but never used. Flagged with W=1
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-09-09 23:53 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-07 20:57 [PATCH net-next] rtnetlink: remove unused ifla_stats_policy Stephen Hemminger
2016-09-09 0:23 ` David Miller
2016-09-09 2:56 ` Roopa Prabhu
2016-09-09 23:53 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).