* [PATCH net-next] macsec: set network devtype
@ 2016-09-07 21:07 Stephen Hemminger
2016-09-09 0:24 ` David Miller
2016-09-09 23:53 ` David Miller
0 siblings, 2 replies; 4+ messages in thread
From: Stephen Hemminger @ 2016-09-07 21:07 UTC (permalink / raw)
To: David Miller, Sabrina Dubroca; +Cc: netdev
The netdevice type structure for macsec was being defined but never used.
To set the network device type the macro SET_NETDEV_DEVTYPE must be called.
Compile tested only, I don't use macsec.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
--- a/drivers/net/macsec.c 2016-08-25 17:20:20.671031972 -0700
+++ b/drivers/net/macsec.c 2016-09-07 14:03:01.676238097 -0700
@@ -2973,6 +2973,7 @@ static void macsec_setup(struct net_devi
dev->priv_flags |= IFF_NO_QUEUE;
dev->netdev_ops = &macsec_netdev_ops;
dev->destructor = macsec_free_netdev;
+ SET_NETDEV_DEVTYPE(dev, &macsec_type);
eth_zero_addr(dev->broadcast);
}
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] macsec: set network devtype
2016-09-07 21:07 [PATCH net-next] macsec: set network devtype Stephen Hemminger
@ 2016-09-09 0:24 ` David Miller
2016-09-09 15:54 ` Sabrina Dubroca
2016-09-09 23:53 ` David Miller
1 sibling, 1 reply; 4+ messages in thread
From: David Miller @ 2016-09-09 0:24 UTC (permalink / raw)
To: stephen; +Cc: sd, netdev
From: Stephen Hemminger <stephen@networkplumber.org>
Date: Wed, 7 Sep 2016 14:07:32 -0700
> The netdevice type structure for macsec was being defined but never used.
> To set the network device type the macro SET_NETDEV_DEVTYPE must be called.
> Compile tested only, I don't use macsec.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Sabrina, please review.
Thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] macsec: set network devtype
2016-09-09 0:24 ` David Miller
@ 2016-09-09 15:54 ` Sabrina Dubroca
0 siblings, 0 replies; 4+ messages in thread
From: Sabrina Dubroca @ 2016-09-09 15:54 UTC (permalink / raw)
To: David Miller; +Cc: stephen, netdev
2016-09-08, 17:24:07 -0700, David Miller wrote:
> From: Stephen Hemminger <stephen@networkplumber.org>
> Date: Wed, 7 Sep 2016 14:07:32 -0700
>
> > The netdevice type structure for macsec was being defined but never used.
> > To set the network device type the macro SET_NETDEV_DEVTYPE must be called.
> > Compile tested only, I don't use macsec.
> >
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>
> Sabrina, please review.
>
> Thanks.
Sorry for the delay. LGTM:
Acked-by: Sabrina Dubroca <sd@queasysnail.net>
--
Sabrina
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] macsec: set network devtype
2016-09-07 21:07 [PATCH net-next] macsec: set network devtype Stephen Hemminger
2016-09-09 0:24 ` David Miller
@ 2016-09-09 23:53 ` David Miller
1 sibling, 0 replies; 4+ messages in thread
From: David Miller @ 2016-09-09 23:53 UTC (permalink / raw)
To: stephen; +Cc: sd, netdev
From: Stephen Hemminger <stephen@networkplumber.org>
Date: Wed, 7 Sep 2016 14:07:32 -0700
> The netdevice type structure for macsec was being defined but never used.
> To set the network device type the macro SET_NETDEV_DEVTYPE must be called.
> Compile tested only, I don't use macsec.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-09-09 23:53 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-07 21:07 [PATCH net-next] macsec: set network devtype Stephen Hemminger
2016-09-09 0:24 ` David Miller
2016-09-09 15:54 ` Sabrina Dubroca
2016-09-09 23:53 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).