From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org, brouer@redhat.com, ffusco@redhat.com,
maze@google.com
Subject: Re: [PATCH net-next] ipv4: accept u8 in IP_TOS ancillary data
Date: Thu, 08 Sep 2016 17:46:27 -0700 (PDT) [thread overview]
Message-ID: <20160908.174627.1650810290451032959.davem@davemloft.net> (raw)
In-Reply-To: <1473310376.15733.26.camel@edumazet-glaptop3.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Wed, 07 Sep 2016 21:52:56 -0700
> From: Eric Dumazet <edumazet@google.com>
>
> In commit f02db315b8d8 ("ipv4: IP_TOS and IP_TTL can be specified as
> ancillary data") Francesco added IP_TOS values specified as integer.
>
> However, kernel sends to userspace (at recvmsg() time) an IP_TOS value
> in a single byte, when IP_RECVTOS is set on the socket.
>
> It can be very useful to reflect all ancillary options as given by the
> kernel in a subsequent sendmsg(), instead of aborting the sendmsg() with
> EINVAL after Francesco patch.
>
> So this patch extends IP_TOS ancillary to accept an u8, so that an UDP
> server can simply reuse same ancillary block without having to mangle
> it.
>
> Jesper can then augment
> https://github.com/netoptimizer/network-testing/blob/master/src/udp_example02.c
> to add TOS reflection ;)
>
> Fixes: f02db315b8d8 ("ipv4: IP_TOS and IP_TTL can be specified as ancillary data")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Applied, thanks Eric.
prev parent reply other threads:[~2016-09-09 0:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-08 4:52 [PATCH net-next] ipv4: accept u8 in IP_TOS ancillary data Eric Dumazet
2016-09-08 9:15 ` Jesper Dangaard Brouer
2016-09-08 13:31 ` Eric Dumazet
2016-09-13 7:07 ` Jesper Dangaard Brouer
2016-09-09 0:46 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160908.174627.1650810290451032959.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=brouer@redhat.com \
--cc=eric.dumazet@gmail.com \
--cc=ffusco@redhat.com \
--cc=maze@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).