From: Ingo Molnar <mingo@kernel.org>
To: Daniel Borkmann <daniel@iogearbox.net>
Cc: Peter Zijlstra <peterz@infradead.org>,
Alexei Starovoitov <alexei.starovoitov@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Arnd Bergmann <arnd@arndb.de>,
netdev@vger.kernel.org, Alexei Starovoitov <ast@kernel.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Alexei Starovoitov <ast@fb.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH, net-next] perf, bpf: fix conditional call to bpf_overflow_handler
Date: Thu, 8 Sep 2016 11:40:17 +0200 [thread overview]
Message-ID: <20160908094017.GA11752@gmail.com> (raw)
In-Reply-To: <57D11B6D.7080205@iogearbox.net>
* Daniel Borkmann <daniel@iogearbox.net> wrote:
> On 09/08/2016 09:01 AM, Ingo Molnar wrote:
> >* Peter Zijlstra <peterz@infradead.org> wrote:
> >>On Thu, Sep 08, 2016 at 08:30:52AM +0200, Ingo Molnar wrote:
> >>>>Thanks for the fix. Just saw build bot complaining last night and
> >>>>by the morning your fix is already here. Thanks!
> >>>
> >>>Guys, this is the first time I saw this patch (and presumably there's some other
> >>>patch as well?) - could you please submit it properly for review and get an
> >>>Acked-by from one of the perf maintainers before appying it?
> >>
> >>I was involved with the original patch and Ack'ed it.
> >
> >Neither the Ack nor the Cc:s were preserved in the net-next commit:
> >
> > aa6a5f3cb2b2 ("perf, bpf: add perf events core support for BPF_PROG_TYPE_PERF_EVENT programs")
>
> Afaik patchwork doesn't pick up Acks when they are against the
> cover letter of a series. [...]
That's unfortunate - I usually add them in manually.
> [...] For the series that includes mentioned commit, Peter's Ack is here:
>
> 4df20483ab28 ("Merge branch 'bpf-perf-hw-sw-events'")
Looks good!
Thanks,
Ingo
prev parent reply other threads:[~2016-09-08 9:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-06 13:10 [PATCH, net-next] perf, bpf: fix conditional call to bpf_overflow_handler Arnd Bergmann
2016-09-06 15:33 ` Alexei Starovoitov
2016-09-08 6:30 ` Ingo Molnar
2016-09-08 6:56 ` Peter Zijlstra
2016-09-08 7:01 ` Ingo Molnar
2016-09-08 8:03 ` Daniel Borkmann
2016-09-08 9:40 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160908094017.GA11752@gmail.com \
--to=mingo@kernel.org \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=alexei.starovoitov@gmail.com \
--cc=arnd@arndb.de \
--cc=ast@fb.com \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).