From: Raju Lakkaraju <Raju.Lakkaraju@microsemi.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"f.fainelli@gmail.com" <f.fainelli@gmail.com>,
Allan Nielsen <Allan.Nielsen@microsemi.com>
Subject: Re: [PATCH 3/4] net: phy: Add read driver for Microsemi PHYs.
Date: Thu, 8 Sep 2016 15:12:12 +0530 [thread overview]
Message-ID: <20160908094211.GA4281@microsemi.com> (raw)
In-Reply-To: <20160824131347.GE13406@lunn.ch>
Hi Andrew,
Thank you for review the code and valuable comments.
On Wed, Aug 24, 2016 at 03:13:47PM +0200, Andrew Lunn wrote:
> EXTERNAL EMAIL
>
>
> On Wed, Aug 24, 2016 at 12:27:07PM +0000, Raju Lakkaraju wrote:
> > From: Nagaraju Lakkaraju <Raju.Lakkaraju@microsemi.com>
> >
> > PHY Read support will be added for VSC 85xx Microsemi PHYs.
>
> Why do i need this, when we have SIOCGMIIREG?
>
Microsemi PHY have different pages i.e. Std IEEE, Extended, Extended_2, Extended_3 and
GPIO pages.
When I want to use SIOCGMIIREG, I can read Std IEEE only with SIOCGMIIREG and not other
pages.
phy_read_reg function is debug function where I can read entair PHY registers.
In this function, I set the page number and register address then read register value
as atomic operation.
Do you have any suggestions to implement this function in different ways?
Thanks,
Raju.
next prev parent reply other threads:[~2016-09-08 9:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-24 12:27 [PATCH 3/4] net: phy: Add read driver for Microsemi PHYs Raju Lakkaraju
2016-08-24 13:13 ` Andrew Lunn
2016-09-08 9:42 ` Raju Lakkaraju [this message]
2016-09-08 13:40 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160908094211.GA4281@microsemi.com \
--to=raju.lakkaraju@microsemi.com \
--cc=Allan.Nielsen@microsemi.com \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).