From: Andrew Lunn <andrew@lunn.ch>
To: Raju Lakkaraju <Raju.Lakkaraju@microsemi.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"f.fainelli@gmail.com" <f.fainelli@gmail.com>,
Allan Nielsen <Allan.Nielsen@microsemi.com>
Subject: Re: [PATCH 3/4] net: phy: Add read driver for Microsemi PHYs.
Date: Thu, 8 Sep 2016 15:40:26 +0200 [thread overview]
Message-ID: <20160908134026.GI26445@lunn.ch> (raw)
In-Reply-To: <20160908094211.GA4281@microsemi.com>
> Microsemi PHY have different pages i.e. Std IEEE, Extended,
> Extended_2, Extended_3 and GPIO pages.
Yes, nothing special there. Marvell does the same, and probably
others.
> When I want to use SIOCGMIIREG, I can read Std IEEE only with
> SIOCGMIIREG and not other pages.
So this is purely for your own debug. So you can hack in anything you
want. Just don't submit it for mainline.
Or you can do it properly. Take a look at the sources for
mii-tool. Figure out a way to do it cleanly which will work for all
phys which support multiple pages. Then submit patches which does this
for both your own PHY and one other manufacture. I can help with
Marvell PHYS, if that is what you want.
What will never get accepted is something which is not generic. What
you submit must work for multiple vendors, and you need to submit it
all, from the userspace/kernel space API all the way down to the PHY,
and ideally patches to mii-tool as well.
Andrew
prev parent reply other threads:[~2016-09-08 13:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-24 12:27 [PATCH 3/4] net: phy: Add read driver for Microsemi PHYs Raju Lakkaraju
2016-08-24 13:13 ` Andrew Lunn
2016-09-08 9:42 ` Raju Lakkaraju
2016-09-08 13:40 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160908134026.GI26445@lunn.ch \
--to=andrew@lunn.ch \
--cc=Allan.Nielsen@microsemi.com \
--cc=Raju.Lakkaraju@microsemi.com \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).