From: Stephen Hemminger <stephen@networkplumber.org>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: "D. Herrendoerfer" <d.herrendoerfer@herrendoerfer.name>,
netdev@vger.kernel.org
Subject: Re: [RFC] bridge: MAC learning uevents
Date: Thu, 8 Sep 2016 14:16:26 -0700 [thread overview]
Message-ID: <20160908141626.0ae9025a@xeon-e3> (raw)
In-Reply-To: <9f5db5b9-37dc-91c0-70e2-38644cc5bdb7@gmail.com>
On Thu, 8 Sep 2016 11:30:08 -0700
Florian Fainelli <f.fainelli@gmail.com> wrote:
> On 09/08/2016 10:19 AM, D. Herrendoerfer wrote:
> >
> > On 08 Sep 2016, at 17:39, Stephen Hemminger <stephen@networkplumber.org> wrote:
> >
> >> On Thu, 8 Sep 2016 15:06:16 +0200
> >> "D. Herrendoerfer" <d.herrendoerfer@herrendoerfer.name> wrote:
> >>
> >>> Hello,
> >>>
> >>> I'd like to start a discussion if it makes sense to add an optional feature
> >>>
> >>> to the bridge MAC address learning code to generate kernel uevents for
> >
> > [SNIP]
> >
> >>>
> >>> I'm porting my patch (for 3.10.0) to head, and will make it available, I
> >>> just want some
> >>>
> >>> valuable feedback as early as possible.
> >>>
> >>>
> >>> Thanks, D.Herrendoerfer
> >>
> >> This should be possible by listening for netlink events.
> >> No need for udev interaction.
> >
> > No, there are none, not for changes to the bridge forwarding table, also this would
> > require a tool to continuously listen for changes.
>
> Wat do you expect uevent to solve here that netlink + a monitoring
> program can't?
>
> There is quite a bit of code in net/bridge/br_fdb.c just to deal with
> notifying learned/added MAC addresses, is not that where you should
> start adding what you are after (if that is not supported as of latest
> mainline)?
just like neighbor table modifications, it should be possible to listen for
events with netlink. Doing it through uevent is the wrong model.
next prev parent reply other threads:[~2016-09-08 21:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-08 13:06 [RFC] bridge: MAC learning uevents D. Herrendoerfer
2016-09-08 15:15 ` Andi Kleen
2016-09-08 17:23 ` D. Herrendoerfer
2016-09-08 15:39 ` Stephen Hemminger
2016-09-08 17:19 ` D. Herrendoerfer
2016-09-08 18:30 ` Florian Fainelli
2016-09-08 21:16 ` Stephen Hemminger [this message]
2016-09-09 8:51 ` D. Herrendoerfer
2016-09-09 23:54 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160908141626.0ae9025a@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=d.herrendoerfer@herrendoerfer.name \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).