From: David Miller <davem@davemloft.net>
To: g.nault@alphalink.fr
Cc: netdev@vger.kernel.org, roopa@cumulusnetworks.com, milon@wq.cz,
mkubecek@suse.cz, nicolas.dichtel@6wind.com
Subject: Re: [PATCH net 0/2] ip: fix creation flags reported in RTM_NEWROUTE events
Date: Fri, 09 Sep 2016 16:51:26 -0700 (PDT) [thread overview]
Message-ID: <20160909.165126.2106988715172525727.davem@davemloft.net> (raw)
In-Reply-To: <20160907151850.g3mzjrkhtqddqzwg@alphalink.fr>
From: Guillaume Nault <g.nault@alphalink.fr>
Date: Wed, 7 Sep 2016 17:18:50 +0200
> Netlink messages sent to user-space upon RTM_NEWROUTE events have their
> nlmsg_flags field inconsistently set. While the NLM_F_REPLACE and
> NLM_F_APPEND bits are correctly handled, NLM_F_CREATE and NLM_F_EXCL
> are always 0.
>
> This series sets the NLM_F_CREATE and NLM_F_EXCL bits when applicable,
> for IPv4 and IPv6.
>
> Since IPv6 ignores the NLM_F_APPEND flags in requests, this flag isn't
> reported in RTM_NEWROUTE IPv6 events. This keeps IPv6 internal
> consistency (same flag semantic for user requests and kernel events) at
> the cost of bringing different flag interpretation for IPv4 and IPv6.
I'm applying this series to net-next so that it has time to cook and
expose anything in userland that might break due to these changes.
I briefly considered applying this to net but I think that is
premature at least for the time being.
Thanks.
next prev parent reply other threads:[~2016-09-09 23:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-07 15:18 [PATCH net 0/2] ip: fix creation flags reported in RTM_NEWROUTE events Guillaume Nault
2016-09-07 15:20 ` [PATCH net 1/2] ipv4: fix value of ->nlmsg_flags " Guillaume Nault
2016-09-07 15:21 ` [PATCH net 2/2] ipv6: report NLM_F_CREATE and NLM_F_EXCL flags " Guillaume Nault
2016-09-09 23:51 ` David Miller [this message]
2016-09-12 10:29 ` [PATCH net 0/2] ip: fix creation flags reported " Guillaume Nault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160909.165126.2106988715172525727.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=g.nault@alphalink.fr \
--cc=milon@wq.cz \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=roopa@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).