netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: lucien.xin@gmail.com
Cc: netdev@vger.kernel.org, linux-sctp@vger.kernel.org,
	marcelo.leitner@gmail.com, vyasevich@gmail.com,
	daniel@iogearbox.net
Subject: Re: [PATCH net] sctp: identify chunks that need to be fragmented at IP level
Date: Fri, 09 Sep 2016 19:18:52 -0700 (PDT)	[thread overview]
Message-ID: <20160909.191852.1305298210334990557.davem@davemloft.net> (raw)
In-Reply-To: <d3a35eae75b431862cf96b55dd3a3614a11df8a3.1473328451.git.lucien.xin@gmail.com>

From: Xin Long <lucien.xin@gmail.com>
Date: Thu,  8 Sep 2016 17:54:11 +0800

> From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
> 
> Previously, without GSO, it was easy to identify it: if the chunk didn't
> fit and there was no data chunk in the packet yet, we could fragment at
> IP level. So if there was an auth chunk and we were bundling a big data
> chunk, it would fragment regardless of the size of the auth chunk. This
> also works for the context of PMTU reductions.
> 
> But with GSO, we cannot distinguish such PMTU events anymore, as the
> packet is allowed to exceed PMTU.
> 
> So we need another check: to ensure that the chunk that we are adding,
> actually fits the current PMTU. If it doesn't, trigger a flush and let
> it be fragmented at IP level in the next round.
> 
> Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>

Applied.

      reply	other threads:[~2016-09-10  2:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-08  9:54 [PATCH net] sctp: identify chunks that need to be fragmented at IP level Xin Long
2016-09-10  2:18 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160909.191852.1305298210334990557.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=daniel@iogearbox.net \
    --cc=linux-sctp@vger.kernel.org \
    --cc=lucien.xin@gmail.com \
    --cc=marcelo.leitner@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=vyasevich@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).