From: Steffen Klassert <steffen.klassert@secunet.com>
To: Alexander Duyck <alexander.duyck@gmail.com>
Cc: Netdev <netdev@vger.kernel.org>,
Alexander Duyck <alexander.h.duyck@intel.com>,
Eric Dumazet <eric.dumazet@gmail.com>,
"Marcelo Ricardo Leitner" <marcelo.leitner@gmail.com>
Subject: Re: [PATCH net-next v4] gso: Support partial splitting at the frag_list pointer
Date: Fri, 9 Sep 2016 08:46:45 +0200 [thread overview]
Message-ID: <20160909064645.GW31137@gauss.secunet.com> (raw)
In-Reply-To: <CAKgT0UdieQO3KM1ZdcyczsO7+uNe-fDg9=jkDg-25nuQyiG56A@mail.gmail.com>
On Thu, Sep 08, 2016 at 08:37:47AM -0700, Alexander Duyck wrote:
>
> A few minor things.
>
> First you somehow got a couple spaces in the line before gso_size.
> That is why the two lines above don't line up.
>
> Second it occurred to me that we could have a situation where tail is
> equal to segs in the case of GSO_PARTIAL with an MSS aligned frame.
> To avoid doing duplicate division we might want to make the else an
> "else if (tail != segs)"
>
> Finally I think the value for the division should be tail->len -
> doffset, not tail->len as we shouldn't include the header data in the
> size as it might cause us to report more packets then we actually
> generate.
>
> I think that should cover all of it. Sorry for the thrash.
Never mind, I do a v5. Better one more iteration of review than a
suboptimal patch.
prev parent reply other threads:[~2016-09-09 6:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-08 11:33 [PATCH net-next v4] gso: Support partial splitting at the frag_list pointer Steffen Klassert
2016-09-08 15:37 ` Alexander Duyck
2016-09-09 6:46 ` Steffen Klassert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160909064645.GW31137@gauss.secunet.com \
--to=steffen.klassert@secunet.com \
--cc=alexander.duyck@gmail.com \
--cc=alexander.h.duyck@intel.com \
--cc=eric.dumazet@gmail.com \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).