From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: NETDEV <netdev@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
James Morris <jmorris@namei.org>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
Patrick McHardy <kaber@trash.net>,
Andrey Vagin <avagin@openvz.org>,
Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH] net: ip, diag -- Add diag interface for raw sockets
Date: Fri, 9 Sep 2016 23:17:31 +0300 [thread overview]
Message-ID: <20160909201731.GD2366@uranus.lan> (raw)
In-Reply-To: <1473450913.18970.59.camel@edumazet-glaptop3.roam.corp.google.com>
On Fri, Sep 09, 2016 at 12:55:13PM -0700, Eric Dumazet wrote:
> > +
> > + rep = nlmsg_new(sizeof(struct inet_diag_msg) +
> > + sizeof(struct inet_diag_meminfo) + 64,
> > + GFP_KERNEL);
> > + if (!rep)
>
> There is a missing sock_put(sk)
>
> > + return -ENOMEM;
> > +
> > + err = inet_sk_diag_fill(sk, NULL, rep, r,
> > + sk_user_ns(NETLINK_CB(in_skb).sk),
> > + NETLINK_CB(in_skb).portid,
> > + nlh->nlmsg_seq, 0, nlh);
>
> sock_put(sk);
Oh, missed. Thanks lot, Eric, will update!
next prev parent reply other threads:[~2016-09-09 20:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-09 18:26 [PATCH] net: ip, diag -- Add diag interface for raw sockets Cyrill Gorcunov
2016-09-09 19:55 ` Eric Dumazet
2016-09-09 20:17 ` Cyrill Gorcunov [this message]
2016-09-10 16:31 ` David Ahern
2016-09-10 19:31 ` Cyrill Gorcunov
2016-09-10 22:05 ` [PATCH v2] " Cyrill Gorcunov
2016-09-10 22:28 ` David Ahern
2016-09-11 19:17 ` [PATCH v3] " Cyrill Gorcunov
2016-09-13 15:57 ` David Miller
2016-09-13 16:31 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160909201731.GD2366@uranus.lan \
--to=gorcunov@gmail.com \
--cc=avagin@openvz.org \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).