From: David Miller <davem@davemloft.net>
To: chris.brandt@renesas.com
Cc: sergei.shtylyov@cogentembedded.com, horms+renesas@verge.net.au,
geert+renesas@glider.be, daniel@0x0f.com, netdev@vger.kernel.org,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v2] net: ethernet: renesas: sh_eth: add POST registers for rz
Date: Sat, 10 Sep 2016 21:12:05 -0700 (PDT) [thread overview]
Message-ID: <20160910.211205.2263493847383395899.davem@davemloft.net> (raw)
In-Reply-To: <20160907185709.24150-1-chris.brandt@renesas.com>
From: Chris Brandt <chris.brandt@renesas.com>
Date: Wed, 7 Sep 2016 14:57:09 -0400
> Due to a mistake in the hardware manual, the FWSLC and POST1-4 registers
> were not documented and left out of the driver for RZ/A making the CAM
> feature non-operational.
> Additionally, when the offset values for POST1-4 are left blank, the driver
> attempts to set them using an offset of 0xFFFF which can cause a memory
> corruption or panic.
>
> This patch fixes the panic and properly enables CAM.
>
> Reported-by: Daniel Palmer <daniel@0x0f.com>
> Signed-off-by: Chris Brandt <chris.brandt@renesas.com>
Applied, thanks.
prev parent reply other threads:[~2016-09-11 4:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-07 18:57 [PATCH v2] net: ethernet: renesas: sh_eth: add POST registers for rz Chris Brandt
2016-09-09 17:12 ` Sergei Shtylyov
2016-09-09 17:49 ` Sergei Shtylyov
2016-09-09 18:26 ` Chris Brandt
2016-09-11 4:12 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160910.211205.2263493847383395899.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=chris.brandt@renesas.com \
--cc=daniel@0x0f.com \
--cc=geert+renesas@glider.be \
--cc=horms+renesas@verge.net.au \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).