From: David Miller <davem@davemloft.net>
To: rvatsavayi@caviumnetworks.com
Cc: netdev@vger.kernel.org, derek.chickles@caviumnetworks.com,
satananda.burla@caviumnetworks.com,
felix.manlunas@caviumnetworks.com,
raghu.vatsavayi@caviumnetworks.com
Subject: Re: [PATCH net-next 3/5] liquidio CN23XX: Mailbox support
Date: Sat, 10 Sep 2016 21:42:01 -0700 (PDT) [thread overview]
Message-ID: <20160910.214201.116857018916997521.davem@davemloft.net> (raw)
In-Reply-To: <1473451707-26397-4-git-send-email-rvatsavayi@caviumnetworks.com>
From: Raghu Vatsavayi <rvatsavayi@caviumnetworks.com>
Date: Fri, 9 Sep 2016 13:08:25 -0700
> +int octeon_mbox_read(struct octeon_mbox *mbox)
> +{
> + int ret = 0;
> + union octeon_mbox_message msg;
> +
Please always order local variable declarations from longest
to shortest line.
Please audit your entire submission for this problem.
next prev parent reply other threads:[~2016-09-11 4:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-09 20:08 [PATCH net-next 0/5] liquidio CN23XX VF support Raghu Vatsavayi
2016-09-09 20:08 ` [PATCH net-next 1/5] liquidio CN23XX: VF config support Raghu Vatsavayi
2016-09-09 20:08 ` [PATCH net-next 2/5] liquidio CN23XX: sriov enable Raghu Vatsavayi
2016-09-11 12:53 ` Yuval Mintz
2016-09-09 20:08 ` [PATCH net-next 3/5] liquidio CN23XX: Mailbox support Raghu Vatsavayi
2016-09-11 4:42 ` David Miller [this message]
2016-09-14 1:25 ` Vatsavayi, Raghu
2016-09-09 20:08 ` [PATCH net-next 4/5] liquidio CN23XX: mailbox interrupt processing Raghu Vatsavayi
2016-09-09 20:08 ` [PATCH net-next 5/5] liquidio CN23XX: VF related operations Raghu Vatsavayi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160910.214201.116857018916997521.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=derek.chickles@caviumnetworks.com \
--cc=felix.manlunas@caviumnetworks.com \
--cc=netdev@vger.kernel.org \
--cc=raghu.vatsavayi@caviumnetworks.com \
--cc=rvatsavayi@caviumnetworks.com \
--cc=satananda.burla@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).