From: Andrew Lunn <andrew@lunn.ch>
To: Jarod Wilson <jarod@redhat.com>
Cc: David Miller <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: Minimum MTU Mess
Date: Mon, 12 Sep 2016 04:41:40 +0200 [thread overview]
Message-ID: <20160912024140.GA6264@lunn.ch> (raw)
In-Reply-To: <20160909180555.GE20632@redhat.com>
> Actually breaking this up into easily digestable/mergeable chunks is going
> to be kind of entertaining... Suggestions welcomed on that. First up is
> obviously the core change, which touches just net/ethernet/eth.c,
> net/core/dev.c, include/linux/netdevice.h and
> include/uapi/linux/if_ether.h, and should let existing code continue to
> Just Work(tm), though devices using ether_setup() that had no MTU range
> checking (or one or the other missing) will wind up with new bounds.
Hi Jarod
Did you find any drivers which support jumbo packets, but don't have
checks? These drivers, if there are any, need handling first, before
this core change is made. Otherwise you introduce regressions.
Andrew
next prev parent reply other threads:[~2016-09-12 2:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-02 17:07 Minimum MTU Mess Jarod Wilson
2016-09-06 16:50 ` [PATCH net-next] sfc: check MTU against minimum threshold Bert Kenward
2016-09-06 21:31 ` Jarod Wilson
2016-09-06 23:54 ` David Miller
2016-09-06 23:55 ` Minimum MTU Mess David Miller
2016-09-07 19:53 ` Jarod Wilson
2016-09-07 20:31 ` Andrew Lunn
2016-09-07 23:43 ` Jarod Wilson
2016-09-08 1:24 ` Andrew Lunn
2016-09-09 18:05 ` Jarod Wilson
2016-09-12 2:41 ` Andrew Lunn [this message]
2016-09-12 14:27 ` Jarod Wilson
2016-09-07 20:35 ` Stephen Hemminger
2016-09-07 23:44 ` Jarod Wilson
2016-09-12 2:59 ` YOSHIFUJI Hideaki
2016-09-12 14:31 ` Jarod Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160912024140.GA6264@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=jarod@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).