* [PATCH] atm: iphase: fix newline escape and minor tweak to source formatting
@ 2016-09-12 9:29 Colin King
2016-09-12 11:55 ` Sergei Shtylyov
2016-09-12 11:55 ` Sergei Shtylyov
0 siblings, 2 replies; 3+ messages in thread
From: Colin King @ 2016-09-12 9:29 UTC (permalink / raw)
To: Chas Williams, linux-atm-general, netdev; +Cc: linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The newline escape is incorrect and needs fixing. Also adjust source
formatting / indentation and remove trailing white space.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/atm/iphase.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/atm/iphase.c b/drivers/atm/iphase.c
index 9d8807e..256b191 100644
--- a/drivers/atm/iphase.c
+++ b/drivers/atm/iphase.c
@@ -1885,9 +1885,8 @@ static int open_tx(struct atm_vcc *vcc)
if ((ret = ia_cbr_setup (iadev, vcc)) < 0) {
return ret;
}
- }
- else
- printk("iadev: Non UBR, ABR and CBR traffic not supportedn");
+ } else
+ printk("iadev: Non UBR, ABR and CBR traffic not supported\n");
iadev->testTable[vcc->vci]->vc_status |= VC_ACTIVE;
IF_EVENT(printk("ia open_tx returning \n");)
--
2.9.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] atm: iphase: fix newline escape and minor tweak to source formatting
2016-09-12 9:29 [PATCH] atm: iphase: fix newline escape and minor tweak to source formatting Colin King
@ 2016-09-12 11:55 ` Sergei Shtylyov
2016-09-12 11:55 ` Sergei Shtylyov
1 sibling, 0 replies; 3+ messages in thread
From: Sergei Shtylyov @ 2016-09-12 11:55 UTC (permalink / raw)
To: Colin King, Chas Williams, linux-atm-general, netdev; +Cc: linux-kernel
Hello.
On 9/12/2016 12:29 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The newline escape is incorrect and needs fixing. Also adjust source
> formatting / indentation and remove trailing white space.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/atm/iphase.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/atm/iphase.c b/drivers/atm/iphase.c
> index 9d8807e..256b191 100644
> --- a/drivers/atm/iphase.c
> +++ b/drivers/atm/iphase.c
> @@ -1885,9 +1885,8 @@ static int open_tx(struct atm_vcc *vcc)
> if ((ret = ia_cbr_setup (iadev, vcc)) < 0) {
> return ret;
> }
> - }
> - else
> - printk("iadev: Non UBR, ABR and CBR traffic not supportedn");
> + } else
> + printk("iadev: Non UBR, ABR and CBR traffic not supported\n");
All branches of the *if* statement should have {} if at least one has
them, perhaps a material for a follow-up patch).
[...]
MBR, Sergei
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] atm: iphase: fix newline escape and minor tweak to source formatting
2016-09-12 9:29 [PATCH] atm: iphase: fix newline escape and minor tweak to source formatting Colin King
2016-09-12 11:55 ` Sergei Shtylyov
@ 2016-09-12 11:55 ` Sergei Shtylyov
1 sibling, 0 replies; 3+ messages in thread
From: Sergei Shtylyov @ 2016-09-12 11:55 UTC (permalink / raw)
To: Colin King, Chas Williams, linux-atm-general, netdev; +Cc: linux-kernel
Hello.
On 9/12/2016 12:29 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The newline escape is incorrect and needs fixing. Also adjust source
> formatting / indentation and remove trailing white space.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/atm/iphase.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/atm/iphase.c b/drivers/atm/iphase.c
> index 9d8807e..256b191 100644
> --- a/drivers/atm/iphase.c
> +++ b/drivers/atm/iphase.c
> @@ -1885,9 +1885,8 @@ static int open_tx(struct atm_vcc *vcc)
> if ((ret = ia_cbr_setup (iadev, vcc)) < 0) {
> return ret;
> }
> - }
> - else
> - printk("iadev: Non UBR, ABR and CBR traffic not supportedn");
> + } else
> + printk("iadev: Non UBR, ABR and CBR traffic not supported\n");
All branches of the *if* statement should have {} if at least one has them
(perhaps a material for a follow-up patch).
[...]
MBR, Sergei
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-09-12 11:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-12 9:29 [PATCH] atm: iphase: fix newline escape and minor tweak to source formatting Colin King
2016-09-12 11:55 ` Sergei Shtylyov
2016-09-12 11:55 ` Sergei Shtylyov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).